yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(rpc): improve internal error for unexpected rpc message (#3734)

Browse Source 
Sometimes I see "cannot call emit on the undefined" error on the bots.
This change adds some more logging, so we could potentially identify where
the issue comes from.
This commit is contained in:
Dmitry Gozman 2020-09-02 12:56:50 -07:00 committed by GitHub
parent df12264655
commit be5eba0cd8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/client/connection.ts
View File

@ -86,7 +86,9 @@ export class Connection {
const { id, guid, method, params, result, error } = message as any;
if (id) {
debugLogger.log('channel:response', message);
const callback = this._callbacks.get(id)!;
const callback = this._callbacks.get(id);
if (!callback)
throw new Error(`Cannot find command to respond: ${id}`);
this._callbacks.delete(id);
if (error)
callback.reject(parseError(error));
@ -101,10 +103,15 @@ export class Connection {
return;
}
if (method === '__dispose__') {
this._objects.get(guid)!._dispose();
const object = this._objects.get(guid);
if (!object)
throw new Error(`Cannot find object to dispose: ${guid}`);
object._dispose();
return;
}
const object = this._objects.get(guid)!;
const object = this._objects.get(guid);
if (!object)
throw new Error(`Cannot find object to call "${method}": ${guid}`);
object._channel.emit(method, this._replaceGuidsWithChannels(params));
}