yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(runner): filter only after duplicate titles check (#15401)

Browse Source
This commit is contained in:
Dmitry Gozman 2022-07-06 12:51:26 -07:00 committed by GitHub
parent 12c7e82fb7
commit c02d83fb11
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 48 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
packages/playwright-test/src/runner.ts
View File

@ -273,25 +273,25 @@ export class Runner {
preprocessRoot._addSuite(fileSuite);
}
// 2. Filter tests to respect line/column filter.
// 2. Complain about duplicate titles.
const duplicateTitlesError = createDuplicateTitlesError(config, preprocessRoot);
if (duplicateTitlesError)
fatalErrors.push(duplicateTitlesError);
// 3. Filter tests to respect line/column filter.
filterByFocusedLine(preprocessRoot, testFileReFilters);
// 3. Complain about only.
// 4. Complain about only.
if (config.forbidOnly) {
const onlyTestsAndSuites = preprocessRoot._getOnlyItems();
if (onlyTestsAndSuites.length > 0)
fatalErrors.push(createForbidOnlyError(config, onlyTestsAndSuites));
}
// 4. Filter only
// 5. Filter only.
if (!list)
filterOnly(preprocessRoot);
// 5. Complain about clashing.
const duplicateTitlesError = createDuplicateTitlesError(config, preprocessRoot);
if (duplicateTitlesError)
fatalErrors.push(duplicateTitlesError);
// 6. Generate projects.
const fileSuites = new Map<string, Suite>();
for (const fileSuite of preprocessRoot.suites)

42
tests/playwright-test/runner.spec.ts
View File

@ -170,7 +170,7 @@ test('should use the first occurring error when an unhandled exception was throw
expect(result.exitCode).toBe(1);
expect(result.passed).toBe(0);
expect(result.failed).toBe(1);
expect(result.report.suites[0].specs[0].tests[0].results[0].error.message).toBe('first error');
expect(result.report.suites[0].specs[0].tests[0].results[0].error!.message).toBe('first error');
});
test('worker interrupt should report errors', async ({ runInlineTest }) => {
@ -303,7 +303,7 @@ test('should not hang if test suites in worker are inconsistent with runner', as
expect(result.passed).toBe(1);
expect(result.failed).toBe(1);
expect(result.skipped).toBe(1);
expect(result.report.suites[0].specs[1].tests[0].results[0].error.message).toBe('Unknown test(s) in worker:\nproject-name > a.spec.js > Test 1 - bar\nproject-name > a.spec.js > Test 2 - baz');
expect(result.report.suites[0].specs[1].tests[0].results[0].error!.message).toBe('Unknown test(s) in worker:\nproject-name > a.spec.js > Test 1 - bar\nproject-name > a.spec.js > Test 2 - baz');
});
test('sigint should stop global setup', async ({ runInlineTest }) => {
@ -423,3 +423,41 @@ test('sigint should stop plugins 2', async ({ runInlineTest }) => {
expect(output).toContain('Plugin1 teardown');
expect(output).not.toContain('Plugin2 teardown');
});
test('should not crash with duplicate titles and .only', async ({ runInlineTest }) => {
const result = await runInlineTest({
'example.spec.ts': `
const { test } = pwt;
test('non unique title', () => { console.log('do not run me'); });
test.skip('non unique title', () => { console.log('do not run me'); });
test.only('non unique title', () => { console.log('do run me'); });
`
});
expect(result.exitCode).toBe(1);
expect(stripAnsi(result.output)).toContain([
` duplicate test titles are not allowed.`,
` - title: non unique title`,
` - example.spec.ts:6`,
` - example.spec.ts:7`,
` - example.spec.ts:8`,
].join('\n'));
});
test('should not crash with duplicate titles and line filter', async ({ runInlineTest }) => {
const result = await runInlineTest({
'example.spec.ts': `
const { test } = pwt;
test('non unique title', () => { console.log('do not run me'); });
test.skip('non unique title', () => { console.log('do not run me'); });
test('non unique title', () => { console.log('do run me'); });
`
}, {}, {}, { additionalArgs: ['example.spec.ts:8'] });
expect(result.exitCode).toBe(1);
expect(stripAnsi(result.output)).toContain([
` duplicate test titles are not allowed.`,
` - title: non unique title`,
` - example.spec.ts:6`,
` - example.spec.ts:7`,
` - example.spec.ts:8`,
].join('\n'));
});