yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: don't mask ESM error (#14628)

Browse Source
This commit is contained in:
Pavel Feldman 2022-06-03 15:28:53 -07:00 committed by GitHub
parent 9711e62882
commit c4b003a29a
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/playwright-test/src/loader.ts
View File

@ -289,9 +289,6 @@ export class Loader {
${'='.repeat(80)}\n`); ${'='.repeat(80)}\n`);
} }
if (error instanceof SyntaxError && error.message.includes('Cannot use import statement outside a module'))
throw errorWithFile(file, 'JavaScript files must end with .mjs to use import.');
throw error; throw error;
} finally { } finally {
revertBabelRequire(); revertBabelRequire();

2
tests/playwright-test/loader.spec.ts
View File

@ -175,7 +175,7 @@ test('should throw a nice error if a js file uses import', async ({ runInlineTes
}); });
expect(exitCode).toBe(1); expect(exitCode).toBe(1);
expect(output).toContain('a.spec.js'); expect(output).toContain('a.spec.js');
expect(output).toContain('JavaScript files must end with .mjs to use import.'); expect(output).toContain('Cannot use import statement outside a module');
}); });
test('should load esm when package.json has type module', async ({ runInlineTest }) => { test('should load esm when package.json has type module', async ({ runInlineTest }) => {