yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: quote trace file path when printing error message (#29052)

Browse Source 
Fixes https://github.com/microsoft/playwright/issues/29039
This commit is contained in:
Yury Semikhatsky 2024-01-18 14:23:12 -08:00 committed by GitHub
parent 4a45724633
commit c76f5294ce
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/playwright/src/reporters/base.ts
View File

@ -331,7 +331,7 @@ export function formatFailure(config: FullConfig, test: TestCase, options: {inde
const packageManagerCommand = getPackageManagerExecCommand(); const packageManagerCommand = getPackageManagerExecCommand();
resultLines.push(colors.cyan(` Usage:`)); resultLines.push(colors.cyan(` Usage:`));
resultLines.push(''); resultLines.push('');
resultLines.push(colors.cyan(` ${packageManagerCommand} playwright show-trace ${relativePath}`)); resultLines.push(colors.cyan(` ${packageManagerCommand} playwright show-trace "${relativePath}"`));
resultLines.push(''); resultLines.push('');
} }
} else { } else {

6
tests/playwright-test/reporter-attachment.spec.ts
View File

@ -66,7 +66,7 @@ test('render trace attachment', async ({ runInlineTest }) => {
test('one', async ({}, testInfo) => { test('one', async ({}, testInfo) => {
testInfo.attachments.push({ testInfo.attachments.push({
name: 'trace', name: 'trace',
path: testInfo.outputPath('trace.zip'), path: testInfo.outputPath('my dir with space', 'trace.zip'),
contentType: 'application/zip' contentType: 'application/zip'
}); });
expect(1).toBe(0); expect(1).toBe(0);
@ -75,8 +75,8 @@ test('render trace attachment', async ({ runInlineTest }) => {
}, { reporter: 'line' }); }, { reporter: 'line' });
const text = result.output.replace(/\\/g, '/'); const text = result.output.replace(/\\/g, '/');
expect(text).toContain(' attachment #1: trace (application/zip) ─────────────────────────────────────────────────────────'); expect(text).toContain(' attachment #1: trace (application/zip) ─────────────────────────────────────────────────────────');
expect(text).toContain(' test-results/a-one/trace.zip'); expect(text).toContain(' test-results/a-one/my dir with space/trace.zip');
expect(text).toContain('npx playwright show-trace test-results/a-one/trace.zip'); expect(text).toContain('npx playwright show-trace "test-results/a-one/my dir with space/trace.zip"');
expect(text).toContain(' ────────────────────────────────────────────────────────────────────────────────────────────────'); expect(text).toContain(' ────────────────────────────────────────────────────────────────────────────────────────────────');
expect(result.exitCode).toBe(1); expect(result.exitCode).toBe(1);
}); });