yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(test-runner): do not list tests to stdout when JSON reporter is used (#7730)

Browse Source
This commit is contained in:
Max Schmitt 2021-07-20 01:10:43 +02:00 committed by GitHub
parent 8eab2d0e5b
commit c84c5c8c9b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 28 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/test/runner.ts
View File

@ -62,12 +62,12 @@ export class Runner {
this._loader = new Loader(defaultConfig, configOverrides); this._loader = new Loader(defaultConfig, configOverrides);
} }
private async _createReporter() { private async _createReporter(list: boolean) {
const reporters: Reporter[] = []; const reporters: Reporter[] = [];
const defaultReporters = { const defaultReporters = {
dot: DotReporter, dot: list ? ListModeReporter : DotReporter,
line: LineReporter, line: list ? ListModeReporter : LineReporter,
list: ListReporter, list: list ? ListModeReporter : ListReporter,
json: JSONReporter, json: JSONReporter,
junit: JUnitReporter, junit: JUnitReporter,
null: EmptyReporter, null: EmptyReporter,
@ -93,7 +93,7 @@ export class Runner {
} }
async run(list: boolean, filePatternFilters: FilePatternFilter[], projectName?: string): Promise<RunResultStatus> { async run(list: boolean, filePatternFilters: FilePatternFilter[], projectName?: string): Promise<RunResultStatus> {
this._reporter = list ? new ListModeReporter() : await this._createReporter(); this._reporter = await this._createReporter(list);
const config = this._loader.fullConfig(); const config = this._loader.fullConfig();
const globalDeadline = config.globalTimeout ? config.globalTimeout + monotonicTime() : undefined; const globalDeadline = config.globalTimeout ? config.globalTimeout + monotonicTime() : undefined;
const { result, timedOut } = await raceAgainstDeadline(this._run(list, filePatternFilters, projectName), globalDeadline); const { result, timedOut } = await raceAgainstDeadline(this._run(list, filePatternFilters, projectName), globalDeadline);

23
tests/playwright-test/list-mode.spec.ts
View File

@ -41,3 +41,26 @@ test('should list tests', async ({ runInlineTest }) => {
`Total: 4 tests in 1 file` `Total: 4 tests in 1 file`
].join('\n')); ].join('\n'));
}); });
test('should not list tests to stdout when JSON reporter is used', async ({ runInlineTest }) => {
const result = await runInlineTest({
'playwright.config.ts': `
module.exports = { projects: [{ name: 'foo' }, {}] };
`,
'a.test.js': `
const { test } = pwt;
test('example1', async ({}) => {
expect(1 + 1).toBe(2);
});
test('example2', async ({}) => {
expect(1 + 1).toBe(2);
});
`
}, { 'list': true, 'reporter': 'json' });
expect(result.exitCode).toBe(0);
expect(result.output).not.toContain('Listing tests');
expect(result.report.config.projects.length).toBe(2);
expect(result.report.suites.length).toBe(1);
expect(result.report.suites[0].specs.length).toBe(2);
expect(result.report.suites[0].specs.map(spec => spec.title)).toStrictEqual(['example1', 'example2']);
});