From c99ca17199936d4082dc5e458777a6a51a29196d Mon Sep 17 00:00:00 2001 From: Pavel Feldman Date: Tue, 10 May 2022 13:55:44 -0800 Subject: [PATCH] chore: disable AvoidUnnecessaryBeforeUnloadCheckSync on chromium (#14080) --- .../playwright-core/src/server/chromium/chromium.ts | 4 +++- packages/playwright-core/src/server/frames.ts | 13 ------------- 2 files changed, 3 insertions(+), 14 deletions(-) diff --git a/packages/playwright-core/src/server/chromium/chromium.ts b/packages/playwright-core/src/server/chromium/chromium.ts index 4c5e86ccf2..bb7203a368 100644 --- a/packages/playwright-core/src/server/chromium/chromium.ts +++ b/packages/playwright-core/src/server/chromium/chromium.ts @@ -320,6 +320,7 @@ export class Chromium extends BrowserType { } const DEFAULT_ARGS = [ + '--disable-field-trial-config', // https://source.chromium.org/chromium/chromium/src/+/main:testing/variations/README.md '--disable-background-networking', '--enable-features=NetworkService,NetworkServiceInProcess', '--disable-background-timer-throttling', @@ -330,7 +331,8 @@ const DEFAULT_ARGS = [ '--disable-default-apps', '--disable-dev-shm-usage', '--disable-extensions', - '--disable-features=ImprovedCookieControls,LazyFrameLoading,GlobalMediaControls,DestroyProfileOnBrowserClose,MediaRouter,DialMediaRouteProvider,AcceptCHFrame,AutoExpandDetailsElement,CertificateTransparencyComponentUpdater', + // AvoidUnnecessaryBeforeUnloadCheckSync - https://github.com/microsoft/playwright/issues/14047 + '--disable-features=ImprovedCookieControls,LazyFrameLoading,GlobalMediaControls,DestroyProfileOnBrowserClose,MediaRouter,DialMediaRouteProvider,AcceptCHFrame,AutoExpandDetailsElement,CertificateTransparencyComponentUpdater,AvoidUnnecessaryBeforeUnloadCheckSync', '--allow-pre-commit-input', '--disable-hang-monitor', '--disable-ipc-flooding-protection', diff --git a/packages/playwright-core/src/server/frames.ts b/packages/playwright-core/src/server/frames.ts index bd6ce267fb..176c55e500 100644 --- a/packages/playwright-core/src/server/frames.ts +++ b/packages/playwright-core/src/server/frames.ts @@ -636,14 +636,6 @@ export class Frame extends SdkObject { } if (event.error) throw event.error; - } else if (isAboutBlank(url)) { - // Workaround chromium issue: https://github.com/microsoft/playwright/issues/14047 - sameDocument.dispose(); - event = await helper.waitForEvent(progress, this, Frame.Events.Navigation, (event: NavigationEvent) => { - return event.newDocument && !event.error; - }).promise; - if (event.error) - throw event.error; } else { event = await sameDocument.promise; } @@ -1755,8 +1747,3 @@ function verifyLifecycle(name: string, waitUntil: types.LifecycleEvent): types.L throw new Error(`${name}: expected one of (load|domcontentloaded|networkidle|commit)`); return waitUntil; } - -function isAboutBlank(url: string) { - return url === 'about:blank' || url.startsWith('about:blank#'); -} -