yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: disable AvoidUnnecessaryBeforeUnloadCheckSync on chromium (#14080)

Browse Source
This commit is contained in:
Pavel Feldman 2022-05-10 13:55:44 -08:00 committed by GitHub
parent a62034a6d6
commit c99ca17199
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/playwright-core/src/server/chromium/chromium.ts
View File

@ -320,6 +320,7 @@ export class Chromium extends BrowserType {
} }
const DEFAULT_ARGS = [ const DEFAULT_ARGS = [
'--disable-field-trial-config', // https://source.chromium.org/chromium/chromium/src/+/main:testing/variations/README.md
'--disable-background-networking', '--disable-background-networking',
'--enable-features=NetworkService,NetworkServiceInProcess', '--enable-features=NetworkService,NetworkServiceInProcess',
'--disable-background-timer-throttling', '--disable-background-timer-throttling',
@ -330,7 +331,8 @@ const DEFAULT_ARGS = [
'--disable-default-apps', '--disable-default-apps',
'--disable-dev-shm-usage', '--disable-dev-shm-usage',
'--disable-extensions', '--disable-extensions',
'--disable-features=ImprovedCookieControls,LazyFrameLoading,GlobalMediaControls,DestroyProfileOnBrowserClose,MediaRouter,DialMediaRouteProvider,AcceptCHFrame,AutoExpandDetailsElement,CertificateTransparencyComponentUpdater', // AvoidUnnecessaryBeforeUnloadCheckSync - https://github.com/microsoft/playwright/issues/14047
'--disable-features=ImprovedCookieControls,LazyFrameLoading,GlobalMediaControls,DestroyProfileOnBrowserClose,MediaRouter,DialMediaRouteProvider,AcceptCHFrame,AutoExpandDetailsElement,CertificateTransparencyComponentUpdater,AvoidUnnecessaryBeforeUnloadCheckSync',
'--allow-pre-commit-input', '--allow-pre-commit-input',
'--disable-hang-monitor', '--disable-hang-monitor',
'--disable-ipc-flooding-protection', '--disable-ipc-flooding-protection',

13
packages/playwright-core/src/server/frames.ts
View File

@ -636,14 +636,6 @@ export class Frame extends SdkObject {
} }
if (event.error) if (event.error)
throw event.error; throw event.error;
} else if (isAboutBlank(url)) {
// Workaround chromium issue: https://github.com/microsoft/playwright/issues/14047
sameDocument.dispose();
event = await helper.waitForEvent(progress, this, Frame.Events.Navigation, (event: NavigationEvent) => {
return event.newDocument && !event.error;
}).promise;
if (event.error)
throw event.error;
} else { } else {
event = await sameDocument.promise; event = await sameDocument.promise;
} }
@ -1755,8 +1747,3 @@ function verifyLifecycle(name: string, waitUntil: types.LifecycleEvent): types.L
throw new Error(`${name}: expected one of (load|domcontentloaded|networkidle|commit)`); throw new Error(`${name}: expected one of (load|domcontentloaded|networkidle|commit)`);
return waitUntil; return waitUntil;
} }
function isAboutBlank(url: string) {
return url === 'about:blank' || url.startsWith('about:blank#');
}