From ca49d50b9c1da4c7dacfe3b8a012cb4d98c32703 Mon Sep 17 00:00:00 2001
From: Joel Einbinder <joel.einbinder@gmail.com>
Date: Thu, 30 Jan 2020 14:53:38 -0800
Subject: [PATCH] test: disable firefox popup tests that rely on
 waitForLoadState (#768)

We have a race between opening a popup and calling waitForLoadState that sometimes causes waitForLoadState to timeout.
---
 test/page.spec.js | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/test/page.spec.js b/test/page.spec.js
index a8993a726f..f60aa05c01 100644
--- a/test/page.spec.js
+++ b/test/page.spec.js
@@ -139,7 +139,7 @@ module.exports.describe = function({testRunner, expect, headless, playwright, FF
       expect(await page.evaluate(() => !!window.opener)).toBe(false);
       expect(await popup.evaluate(() => !!window.opener)).toBe(false);
     });
-    it('should work with clicking target=_blank', async({page, server}) => {
+    it.skip(FFOX)('should work with clicking target=_blank', async({page, server}) => {
       await page.goto(server.EMPTY_PAGE);
       await page.setContent('<a target=_blank rel="opener" href="/one-style.html">yo</a>');
       const [popup] = await Promise.all([
@@ -162,7 +162,7 @@ module.exports.describe = function({testRunner, expect, headless, playwright, FF
       // FFOX is slow enough to trigger this. We should do something about popups api.
       expect(await popup.evaluate(() => !!window.opener)).toBe(false);
     });
-    it('should work with clicking target=_blank and rel=noopener', async({page, server}) => {
+    it.skip(FFOX)('should work with clicking target=_blank and rel=noopener', async({page, server}) => {
       await page.goto(server.EMPTY_PAGE);
       await page.setContent('<a target=_blank rel=noopener href="/one-style.html">yo</a>');
       const [popup] = await Promise.all([