yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix TypeError in codegen (#35921)

Browse Source
This commit is contained in:
Rui Figueira 2025-05-12 08:28:44 +01:00 committed by GitHub
parent d476f1d3b4
commit cd32b0a231
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/injected/src/recorder/recorder.ts
View File

@ -545,6 +545,10 @@ class RecordActionTool implements RecorderTool {
} }
private _shouldGenerateKeyPressFor(event: KeyboardEvent): boolean { private _shouldGenerateKeyPressFor(event: KeyboardEvent): boolean {
// IME can generate keyboard events that don't provide a value for the key property (e.g. chrome autofill)
if (typeof event.key !== 'string')
return false;
// Enter aka. new line is handled in input event. // Enter aka. new line is handled in input event.
if (event.key === 'Enter' && (this._recorder.deepEventTarget(event).nodeName === 'TEXTAREA' || this._recorder.deepEventTarget(event).isContentEditable)) if (event.key === 'Enter' && (this._recorder.deepEventTarget(event).nodeName === 'TEXTAREA' || this._recorder.deepEventTarget(event).isContentEditable))
return false; return false;