yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

devops: fix crash in build.js watch mode with SyntaxError (#35904)

Browse Source
This commit is contained in:
Max Schmitt 2025-05-09 14:08:50 +02:00 committed by GitHub
parent 0876b99a4d
commit d178b4dbaf
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
utils/build/build.js
View File

@ -287,7 +287,7 @@ class EsbuildStep extends Step {
if (watchMode) { if (watchMode) {
await this._ensureWatching(); await this._ensureWatching();
} else { } else {
console.log('==== Running esbuild', this._options.entryPoints); console.log('==== Running esbuild', this._options.entryPoints.map(e => path.relative(ROOT, e)).join(', '));
const start = Date.now(); const start = Date.now();
await build(this._options); await build(this._options);
console.log('==== Done in', Date.now() - start, 'ms'); console.log('==== Done in', Date.now() - start, 'ms');
@ -316,7 +316,13 @@ class EsbuildStep extends Step {
do { do {
this._sourcesChanged = false; this._sourcesChanged = false;
this._rebuilding = true; this._rebuilding = true;
await this._context?.rebuild(); try {
await this._context?.rebuild();
} catch (e) {
console.error('Rebuild failed:', e);
}
this._rebuilding = false; this._rebuilding = false;
} while (this._sourcesChanged); } while (this._sourcesChanged);
} }