From d1f937d651cf904be1dd51064d4451bafc42c322 Mon Sep 17 00:00:00 2001 From: Yury Semikhatsky Date: Mon, 20 Jul 2020 10:44:11 -0700 Subject: [PATCH] browser(firefox): stop video recording if page closed (#3040) --- browser_patches/firefox/BUILD_NUMBER | 4 ++-- browser_patches/firefox/juggler/protocol/PageHandler.js | 2 ++ 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/browser_patches/firefox/BUILD_NUMBER b/browser_patches/firefox/BUILD_NUMBER index 0d541dc2d4..25c0ac95bb 100644 --- a/browser_patches/firefox/BUILD_NUMBER +++ b/browser_patches/firefox/BUILD_NUMBER @@ -1,2 +1,2 @@ -1131 -Changed: yurys@chromium.org Fri Jul 17 17:30:24 PDT 2020 +1132 +Changed: yurys@chromium.org Mon Jul 20 10:26:17 PDT 2020 diff --git a/browser_patches/firefox/juggler/protocol/PageHandler.js b/browser_patches/firefox/juggler/protocol/PageHandler.js index fc061dbc74..872d324b3e 100644 --- a/browser_patches/firefox/juggler/protocol/PageHandler.js +++ b/browser_patches/firefox/juggler/protocol/PageHandler.js @@ -137,6 +137,8 @@ class PageHandler { dispose() { this._contentPage.dispose(); helper.removeListeners(this._eventListeners); + if (this._videoSessionId !== -1) + this.stopVideoRecording().catch(e => dump(`stopVideoRecording failed:\n${e}\n`)); } async setViewportSize({viewportSize}) {