yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: don't fail on undefined video/trace (#17999)

Browse Source 
Fixes #17396
This commit is contained in:
Pavel Feldman 2022-10-11 09:10:43 -08:00 committed by GitHub
parent 1a43af3fb6
commit d5c4291a89
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/playwright-test/src/index.ts
View File

@ -579,7 +579,9 @@ type ParsedStackTrace = {
apiName: string; apiName: string;
}; };
export function normalizeVideoMode(video: VideoMode | 'retry-with-video' | { mode: VideoMode }) { export function normalizeVideoMode(video: VideoMode | 'retry-with-video' | { mode: VideoMode } | undefined): VideoMode {
if (!video)
return 'off';
let videoMode = typeof video === 'string' ? video : video.mode; let videoMode = typeof video === 'string' ? video : video.mode;
if (videoMode === 'retry-with-video') if (videoMode === 'retry-with-video')
videoMode = 'on-first-retry'; videoMode = 'on-first-retry';
@ -590,7 +592,9 @@ export function shouldCaptureVideo(videoMode: VideoMode, testInfo: TestInfo) {
return (videoMode === 'on' || videoMode === 'retain-on-failure' || (videoMode === 'on-first-retry' && testInfo.retry === 1)); return (videoMode === 'on' || videoMode === 'retain-on-failure' || (videoMode === 'on-first-retry' && testInfo.retry === 1));
} }
export function normalizeTraceMode(trace: TraceMode | 'retry-with-trace' | { mode: TraceMode }) { export function normalizeTraceMode(trace: TraceMode | 'retry-with-trace' | { mode: TraceMode } | undefined): TraceMode {
if (!trace)
return 'off';
let traceMode = typeof trace === 'string' ? trace : trace.mode; let traceMode = typeof trace === 'string' ? trace : trace.mode;
if (traceMode === 'retry-with-trace') if (traceMode === 'retry-with-trace')
traceMode = 'on-first-retry'; traceMode = 'on-first-retry';