yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore(bidi): rename bidi-firefox-stable to moz-firefox channel (#35611)

Browse Source
This commit is contained in:
Yury Semikhatsky 2025-04-14 17:30:00 -07:00 committed by GitHub
parent 6262a1264f
commit d79bb57ac1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 9 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
.github/workflows/tests_bidi.yml vendored
View File

@ -32,7 +32,7 @@ jobs:
strategy:
fail-fast: false
matrix:
channel: [bidi-chromium, bidi-firefox-nightly]
channel: [bidi-chromium, moz-firefox]
steps:
- uses: actions/checkout@v4
if: github.event_name != 'workflow_dispatch'
@ -47,7 +47,7 @@ jobs:
- run: npm run build
- run: npx playwright install --with-deps chromium
if: matrix.channel == 'bidi-chromium'
- if: matrix.channel == 'bidi-firefox-nightly'
- if: matrix.channel == 'moz-firefox'
id: install_firefox
run: |
npx -y @puppeteer/browsers install firefox@nightly |\

8
packages/playwright-core/src/server/registry/index.ts
View File

@ -475,7 +475,7 @@ function readDescriptors(browsersJSON: BrowsersJSON): BrowsersJSONDescriptor[] {
export type BrowserName = 'chromium' | 'firefox' | 'webkit' | 'bidi';
type InternalTool = 'ffmpeg' | 'winldd' | 'firefox-beta' | 'chromium-tip-of-tree' | 'chromium-headless-shell' | 'chromium-tip-of-tree-headless-shell' | 'android';
type BidiChannel = 'bidi-firefox-stable' | 'bidi-firefox-beta' | 'bidi-firefox-nightly' | 'bidi-chrome-canary' | 'bidi-chrome-stable' | 'bidi-chromium';
type BidiChannel = 'moz-firefox' | 'moz-firefox-beta' | 'moz-firefox-nightly' | 'bidi-chrome-canary' | 'bidi-chrome-stable' | 'bidi-chromium';
type ChromiumChannel = 'chrome' | 'chrome-beta' | 'chrome-dev' | 'chrome-canary' | 'msedge' | 'msedge-beta' | 'msedge-dev' | 'msedge-canary';
const allDownloadable = ['android', 'chromium', 'firefox', 'webkit', 'ffmpeg', 'firefox-beta', 'chromium-tip-of-tree', 'chromium-headless-shell', 'chromium-tip-of-tree-headless-shell'];
@ -682,17 +682,17 @@ export class Registry {
'win32': `\\Microsoft\\Edge SxS\\Application\\msedge.exe`,
}));
this._executables.push(this._createBidiFirefoxChannel('bidi-firefox-stable', {
this._executables.push(this._createBidiFirefoxChannel('moz-firefox', {
'linux': '/snap/bin/firefox',
'darwin': '/Applications/Firefox.app/Contents/MacOS/firefox',
'win32': '\\Mozilla Firefox\\firefox.exe',
}));
this._executables.push(this._createBidiFirefoxChannel('bidi-firefox-beta', {
this._executables.push(this._createBidiFirefoxChannel('moz-firefox-beta', {
'linux': '/opt/firefox-beta/firefox',
'darwin': '/Applications/Firefox.app/Contents/MacOS/firefox',
'win32': '\\Mozilla Firefox\\firefox.exe',
}));
this._executables.push(this._createBidiFirefoxChannel('bidi-firefox-nightly', {
this._executables.push(this._createBidiFirefoxChannel('moz-firefox-nightly', {
'linux': '/opt/firefox-nightly/firefox',
'darwin': '/Applications/Firefox Nightly.app/Contents/MacOS/firefox',
'win32': '\\Mozilla Firefox\\firefox.exe',

4
tests/bidi/README.md
View File

@ -7,7 +7,7 @@ git clone https://github.com/microsoft/playwright.git
cd playwright
npm run build # call `npm run watch` for watch mode
npx playwright install chromium
npm run biditest -- --project='bidi-firefox-beta-*'
npm run biditest -- --project='moz-firefox-*'
```
To install beta channel of Firefox, run the following command in the project root:
@ -16,7 +16,7 @@ npx -y @puppeteer/browsers install firefox@beta
```
After that you need to pass custom firefox binary path to the test runner via `BIDI_FFPATH`:
```sh
BIDI_FFPATH='/Users/myself/playwright/firefox/mac_arm-beta_138.0b5/Firefox.app/Contents/MacOS/firefox' npm run biditest -- --project='bidi-firefox-beta-*'
BIDI_FFPATH='/Users/myself/playwright/firefox/mac_arm-beta_138.0b5/Firefox.app/Contents/MacOS/firefox' npm run biditest -- --project='moz-firefox-*'
```
For custom Chromium path use `BIDI_CRPATH`.

2
tests/bidi/playwright.config.ts
View File

@ -76,7 +76,7 @@ const getExecutablePath = (browserName: BrowserName) => {
const browserToChannels = {
'_bidiChromium': ['bidi-chromium', 'bidi-chrome-canary', 'bidi-chrome-stable'],
'_bidiFirefox': ['bidi-firefox-nightly', 'bidi-firefox-beta', 'bidi-firefox-stable'],
'_bidiFirefox': ['moz-firefox'],
};
for (const [key, channels] of Object.entries(browserToChannels)) {