yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(remote): send 'x-playwright-browser' header (#12556)

Browse Source
This commit is contained in:
Dmitry Gozman 2022-03-07 10:30:53 -08:00 committed by GitHub
parent 5ca7858ace
commit d836ed41d3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/playwright-core/src/client/browserType.ts
View File

@ -128,7 +128,8 @@ export class BrowserType extends ChannelOwner<channels.BrowserTypeChannel> imple
return await this._wrapApiCall(async () => { return await this._wrapApiCall(async () => {
const deadline = params.timeout ? monotonicTime() + params.timeout : 0; const deadline = params.timeout ? monotonicTime() + params.timeout : 0;
let browser: Browser; let browser: Browser;
const connectParams: channels.BrowserTypeConnectParams = { wsEndpoint, headers: params.headers, slowMo: params.slowMo, timeout: params.timeout }; const headers = { 'x-playwright-browser': this.name(), ...params.headers };
const connectParams: channels.BrowserTypeConnectParams = { wsEndpoint, headers, slowMo: params.slowMo, timeout: params.timeout };
if ((params as any).__testHookRedirectPortForwarding) if ((params as any).__testHookRedirectPortForwarding)
connectParams.socksProxyRedirectPortForTest = (params as any).__testHookRedirectPortForwarding; connectParams.socksProxyRedirectPortForTest = (params as any).__testHookRedirectPortForwarding;
const { pipe } = await this._channel.connect(connectParams); const { pipe } = await this._channel.connect(connectParams);

3
tests/browsertype-connect.spec.ts
View File

@ -134,7 +134,7 @@ test('should send extra headers with connect request', async ({ browserType, sta
expect(request.headers['foo']).toBe('bar'); expect(request.headers['foo']).toBe('bar');
}); });
test('should send default User-Agent header with connect request', async ({ browserType, startRemoteServer, server }) => { test('should send default User-Agent and X-Playwright-Browser headers with connect request', async ({ browserType, browserName, server }) => {
const [request] = await Promise.all([ const [request] = await Promise.all([
server.waitForWebSocketConnectionRequest(), server.waitForWebSocketConnectionRequest(),
browserType.connect({ browserType.connect({
@ -146,6 +146,7 @@ test('should send default User-Agent header with connect request', async ({ brow
}).catch(() => {}) }).catch(() => {})
]); ]);
expect(request.headers['user-agent']).toBe(getUserAgent()); expect(request.headers['user-agent']).toBe(getUserAgent());
expect(request.headers['x-playwright-browser']).toBe(browserName);
expect(request.headers['foo']).toBe('bar'); expect(request.headers['foo']).toBe('bar');
}); });