yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(HEAD): revert GET->HEAD migration, net-effect was negative (#29738)

Browse Source 
Fixes: https://github.com/microsoft/playwright/issues/29732
This commit is contained in:
Pavel Feldman 2024-02-29 09:02:05 -08:00 committed by GitHub
parent 6bd7665bce
commit d9a00342c8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
packages/playwright-core/src/utils/network.ts
View File

@ -181,9 +181,8 @@ export async function isURLAvailable(url: URL, ignoreHTTPSErrors: boolean, onLog
async function httpStatusCode(url: URL, ignoreHTTPSErrors: boolean, onLog?: (data: string) => void, onStdErr?: (data: string) => void): Promise<number> { async function httpStatusCode(url: URL, ignoreHTTPSErrors: boolean, onLog?: (data: string) => void, onStdErr?: (data: string) => void): Promise<number> {
return new Promise(resolve => { return new Promise(resolve => {
onLog?.(`HTTP HEAD: ${url}`); onLog?.(`HTTP GET: ${url}`);
httpRequest({ httpRequest({
method: 'HEAD',
url: url.toString(), url: url.toString(),
headers: { Accept: '*/*' }, headers: { Accept: '*/*' },
rejectUnauthorized: !ignoreHTTPSErrors rejectUnauthorized: !ignoreHTTPSErrors

2
tests/playwright-test/web-server.spec.ts
View File

@ -662,7 +662,7 @@ test('should check ipv4 and ipv6 with happy eyeballs when URL is passed', async
expect(result.exitCode).toBe(0); expect(result.exitCode).toBe(0);
expect(result.passed).toBe(1); expect(result.passed).toBe(1);
expect(result.output).toContain('Process started'); expect(result.output).toContain('Process started');
expect(result.output).toContain(`HTTP HEAD: http://localhost:${port}/`); expect(result.output).toContain(`HTTP GET: http://localhost:${port}/`);
expect(result.output).toContain('WebServer available'); expect(result.output).toContain('WebServer available');
}); });