From da2cecbea008b99541edef37fab60219e9b9bd2b Mon Sep 17 00:00:00 2001 From: Pavel Feldman Date: Fri, 11 Feb 2022 08:11:24 -0800 Subject: [PATCH] chore: don't close page in generated test (#12022) --- .../src/server/supplements/recorder/javascript.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/playwright-core/src/server/supplements/recorder/javascript.ts b/packages/playwright-core/src/server/supplements/recorder/javascript.ts index 1dbffc3127..6317efc19d 100644 --- a/packages/playwright-core/src/server/supplements/recorder/javascript.ts +++ b/packages/playwright-core/src/server/supplements/recorder/javascript.ts @@ -36,14 +36,15 @@ export class JavaScriptLanguageGenerator implements LanguageGenerator { generateAction(actionInContext: ActionInContext): string { const action = actionInContext.action; + if (this._isTest && (action.name === 'openPage' || action.name === 'closePage')) + return ''; + const pageAlias = actionInContext.frame.pageAlias; const formatter = new JavaScriptFormatter(2); formatter.newLine(); formatter.add('// ' + actionTitle(action)); if (action.name === 'openPage') { - if (this._isTest) - return ''; formatter.add(`const ${pageAlias} = await context.newPage();`); if (action.url && action.url !== 'about:blank' && action.url !== 'chrome://newtab/') formatter.add(`await ${pageAlias}.goto(${quote(action.url)});`);