yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

browser(firefox): support start/stop videos for context (#8173)

Browse Source
This commit is contained in:
Dmitry Gozman 2021-08-12 17:17:54 -07:00 committed by GitHub
parent b4920fe699
commit dba3c5055f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
8 changed files with 30 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
browser_patches/firefox-beta/BUILD_NUMBER
View File

@ -1,2 +1,2 @@
1276 1277
Changed: yurys@chromium.org Wed 11 Aug 2021 01:41:01 PM PDT Changed: dgozman@gmail.com Thu Aug 12 16:33:32 PDT 2021

10
browser_patches/firefox-beta/juggler/TargetRegistry.js
View File

@ -917,11 +917,13 @@ class BrowserContext {
async setVideoRecordingOptions(options) { async setVideoRecordingOptions(options) {
this.videoRecordingOptions = options; this.videoRecordingOptions = options;
if (!options)
return;
const promises = []; const promises = [];
for (const page of this.pages) for (const page of this.pages) {
promises.push(page._startVideoRecording(options)); if (options)
promises.push(page._startVideoRecording(options));
else if (page._videoRecordingInfo)
promises.push(page._stopVideoRecording());
}
await Promise.all(promises); await Promise.all(promises);
} }
} }

4
browser_patches/firefox-beta/juggler/protocol/BrowserHandler.js
View File

@ -213,8 +213,8 @@ class BrowserHandler {
await this._targetRegistry.browserContextForId(browserContextId).setForcedColors(nullToUndefined(forcedColors)); await this._targetRegistry.browserContextForId(browserContextId).setForcedColors(nullToUndefined(forcedColors));
} }
async ['Browser.setVideoRecordingOptions']({browserContextId, dir, width, height, scale}) { async ['Browser.setVideoRecordingOptions']({browserContextId, options}) {
await this._targetRegistry.browserContextForId(browserContextId).setVideoRecordingOptions({dir, width, height, scale}); await this._targetRegistry.browserContextForId(browserContextId).setVideoRecordingOptions(options);
} }
async ['Browser.setUserAgentOverride']({browserContextId, userAgent}) { async ['Browser.setUserAgentOverride']({browserContextId, userAgent}) {

8
browser_patches/firefox-beta/juggler/protocol/Protocol.js
View File

@ -453,9 +453,11 @@ const Browser = {
'setVideoRecordingOptions': { 'setVideoRecordingOptions': {
params: { params: {
browserContextId: t.Optional(t.String), browserContextId: t.Optional(t.String),
dir: t.String, options: t.Optional({
width: t.Number, dir: t.String,
height: t.Number, width: t.Number,
height: t.Number,
}),
}, },
}, },
'cancelDownload': { 'cancelDownload': {

4
browser_patches/firefox/BUILD_NUMBER
View File

@ -1,2 +1,2 @@
1282 1283
Changed: yurys@chromium.org Wed 11 Aug 2021 01:40:40 PM PDT Changed: dgozman@gmail.com Thu Aug 12 16:33:32 PDT 2021

10
browser_patches/firefox/juggler/TargetRegistry.js
View File

@ -917,11 +917,13 @@ class BrowserContext {
async setVideoRecordingOptions(options) { async setVideoRecordingOptions(options) {
this.videoRecordingOptions = options; this.videoRecordingOptions = options;
if (!options)
return;
const promises = []; const promises = [];
for (const page of this.pages) for (const page of this.pages) {
promises.push(page._startVideoRecording(options)); if (options)
promises.push(page._startVideoRecording(options));
else if (page._videoRecordingInfo)
promises.push(page._stopVideoRecording());
}
await Promise.all(promises); await Promise.all(promises);
} }
} }

4
browser_patches/firefox/juggler/protocol/BrowserHandler.js
View File

@ -213,8 +213,8 @@ class BrowserHandler {
await this._targetRegistry.browserContextForId(browserContextId).setForcedColors(nullToUndefined(forcedColors)); await this._targetRegistry.browserContextForId(browserContextId).setForcedColors(nullToUndefined(forcedColors));
} }
async ['Browser.setVideoRecordingOptions']({browserContextId, dir, width, height, scale}) { async ['Browser.setVideoRecordingOptions']({browserContextId, options}) {
await this._targetRegistry.browserContextForId(browserContextId).setVideoRecordingOptions({dir, width, height, scale}); await this._targetRegistry.browserContextForId(browserContextId).setVideoRecordingOptions(options);
} }
async ['Browser.setUserAgentOverride']({browserContextId, userAgent}) { async ['Browser.setUserAgentOverride']({browserContextId, userAgent}) {

8
browser_patches/firefox/juggler/protocol/Protocol.js
View File

@ -453,9 +453,11 @@ const Browser = {
'setVideoRecordingOptions': { 'setVideoRecordingOptions': {
params: { params: {
browserContextId: t.Optional(t.String), browserContextId: t.Optional(t.String),
dir: t.String, options: t.Optional({
width: t.Number, dir: t.String,
height: t.Number, width: t.Number,
height: t.Number,
}),
}, },
}, },
'cancelDownload': { 'cancelDownload': {