yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(fetch): ignoreHTTPSErrors after redirects (#9806)

Browse Source
This commit is contained in:
Yury Semikhatsky 2021-10-26 23:20:52 -07:00 committed by GitHub
parent c8addef03a
commit dd0dae623b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
packages/playwright-core/src/server/fetch.ts
View File

@ -231,7 +231,7 @@ export abstract class FetchRequest extends SdkObject {
delete headers[`content-type`]; delete headers[`content-type`];
} }
const redirectOptions: http.RequestOptions & { maxRedirects: number, deadline: number } = { const redirectOptions: https.RequestOptions & { maxRedirects: number, deadline: number } = {
method, method,
headers, headers,
agent: options.agent, agent: options.agent,
@ -239,6 +239,9 @@ export abstract class FetchRequest extends SdkObject {
timeout: options.timeout, timeout: options.timeout,
deadline: options.deadline deadline: options.deadline
}; };
// rejectUnauthorized = undefined is treated as true in node 12.
if (options.rejectUnauthorized === false)
redirectOptions.rejectUnauthorized = false;
// HTTP-redirect fetch step 4: If locationURL is null, then return response. // HTTP-redirect fetch step 4: If locationURL is null, then return response.
if (response.headers.location) { if (response.headers.location) {

7
tests/global-fetch.spec.ts
View File

@ -146,6 +146,13 @@ it('should support global ignoreHTTPSErrors option', async ({ playwright, httpsS
expect(response.status()).toBe(200); expect(response.status()).toBe(200);
}); });
it('should propagate ignoreHTTPSErrors on redirects', async ({ playwright, httpsServer }) => {
httpsServer.setRedirect('/redir', '/empty.html');
const request = await playwright.request.newContext();
const response = await request.get(httpsServer.PREFIX + '/redir', { ignoreHTTPSErrors: true });
expect(response.status()).toBe(200);
});
it('should resolve url relative to gobal baseURL option', async ({ playwright, server }) => { it('should resolve url relative to gobal baseURL option', async ({ playwright, server }) => {
const request = await playwright.request.newContext({ baseURL: server.PREFIX }); const request = await playwright.request.newContext({ baseURL: server.PREFIX });
const response = await request.get('/empty.html'); const response = await request.get('/empty.html');