yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "feat(codegen): add range input recording support (#28767)" (#29069)

Browse Source
This commit is contained in:
Max Schmitt 2024-01-19 19:47:59 +01:00 committed by GitHub
parent 674988c633
commit e551506c9e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 13 additions and 34 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
packages/playwright-core/src/server/injected/recorder.ts
View File

@ -188,7 +188,7 @@ class RecordActionTool implements RecorderTool {
return; return;
if (this._actionInProgress(event)) if (this._actionInProgress(event))
return; return;
if (this._consumedDueWrongTarget(event, this._hoveredModel)) if (this._consumedDueToNoModel(event, this._hoveredModel))
return; return;
const checkbox = asCheckbox(this._recorder.deepEventTarget(event)); const checkbox = asCheckbox(this._recorder.deepEventTarget(event));
@ -283,7 +283,7 @@ class RecordActionTool implements RecorderTool {
} }
// Non-navigating actions are simply recorded by Playwright. // Non-navigating actions are simply recorded by Playwright.
if (this._consumedDueWrongTarget(event, this._activeModel)) if (this._consumedDueWrongTarget(event))
return; return;
this._recorder.delegate.recordAction?.({ this._recorder.delegate.recordAction?.({
name: 'fill', name: 'fill',
@ -313,7 +313,7 @@ class RecordActionTool implements RecorderTool {
this._expectProgrammaticKeyUp = true; this._expectProgrammaticKeyUp = true;
return; return;
} }
if (this._consumedDueWrongTarget(event, this._activeModel)) if (this._consumedDueWrongTarget(event))
return; return;
// Similarly to click, trigger checkbox on key event, not input. // Similarly to click, trigger checkbox on key event, not input.
if (event.key === ' ') { if (event.key === ' ') {
@ -373,7 +373,7 @@ class RecordActionTool implements RecorderTool {
const nodeName = target.nodeName; const nodeName = target.nodeName;
if (nodeName === 'SELECT' || nodeName === 'OPTION') if (nodeName === 'SELECT' || nodeName === 'OPTION')
return true; return true;
if (nodeName === 'INPUT' && ['date', 'range'].includes((target as HTMLInputElement).type)) if (nodeName === 'INPUT' && ['date'].includes((target as HTMLInputElement).type))
return true; return true;
return false; return false;
} }
@ -387,8 +387,15 @@ class RecordActionTool implements RecorderTool {
return false; return false;
} }
private _consumedDueWrongTarget(event: Event, model: HighlightModel | null): boolean { private _consumedDueToNoModel(event: Event, model: HighlightModel | null): boolean {
if (model && model.elements[0] === this._recorder.deepEventTarget(event)) if (model)
return false;
consumeEvent(event);
return true;
}
private _consumedDueWrongTarget(event: Event): boolean {
if (this._activeModel && this._activeModel.elements[0] === this._recorder.deepEventTarget(event))
return false; return false;
consumeEvent(event); consumeEvent(event);
return true; return true;

28
tests/library/inspector/cli-codegen-1.spec.ts
View File

@ -746,32 +746,4 @@ await page.GetByText("Click me").ClickAsync(new LocatorClickOptions
Button = MouseButton.Middle, Button = MouseButton.Middle,
});`); });`);
}); });
test('should record slider', async ({ page, openRecorder }) => {
const recorder = await openRecorder();
await recorder.setContentAndWait(`<input type="range" min="0" max="10" value="5">`);
const dragSlider = async () => {
await page.locator('input').focus();
const { x, y, width, height } = await page.locator('input').boundingBox();
await page.mouse.move(x + width / 2, y + height / 2);
await page.mouse.down();
await page.mouse.move(x + width, y + height / 2);
await page.mouse.up();
};
const [sources] = await Promise.all([
recorder.waitForOutput('JavaScript', 'fill'),
dragSlider(),
]);
await expect(page.locator('input')).toHaveValue('10');
expect(sources.get('JavaScript')!.text).toContain(`
await page.getByRole('slider').fill('10');`);
expect(sources.get('JavaScript')!.text).not.toContain(`
await page.getByRole('slider').click();`);
});
}); });