yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

browser(firefox): pass null for the data transfer (#5723)

Browse Source
This commit is contained in:
Joel Einbinder 2021-03-04 17:20:45 -08:00 committed by GitHub
parent 8ffcbb3808
commit e56f56c11e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
browser_patches/firefox/BUILD_NUMBER
View File

@ -1,2 +1,2 @@
1236 1237
Changed: lushnikov@chromium.org Tue 02 Mar 2021 06:38:43 PM PST Changed: joel.einbinder@gmail.com Thu 04 Mar 2021 05:16:38 PM PST

4
browser_patches/firefox/juggler/content/PageAgent.js
View File

@ -790,8 +790,6 @@ class PageAgent {
const element = window.windowUtils.elementFromPoint(x, y, false, false); const element = window.windowUtils.elementFromPoint(x, y, false, false);
const event = window.document.createEvent('DragEvent'); const event = window.document.createEvent('DragEvent');
const dataTransfer = dragService.getCurrentSession().dataTransfer.mozCloneForEvent(type);
dataTransfer.dropEffect = 'move';
event.initDragEvent( event.initDragEvent(
type, type,
true /* bubble */, true /* bubble */,
@ -808,7 +806,7 @@ class PageAgent {
modifiers & 8 /* metaKey */, modifiers & 8 /* metaKey */,
0 /* button */, // firefox always has the button as 0 on drops, regardless of which was pressed 0 /* button */, // firefox always has the button as 0 on drops, regardless of which was pressed
null /* relatedTarget */, null /* relatedTarget */,
dataTransfer, null,
); );
if (type !== 'drop' || dragService.dragAction) if (type !== 'drop' || dragService.dragAction)
window.windowUtils.dispatchDOMEventViaPresShellForTesting(element, event); window.windowUtils.dispatchDOMEventViaPresShellForTesting(element, event);