yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(ui-mode): prevent OOM crash when DEBUG logging enabled (#35827)

Browse Source
This commit is contained in:
Adam Gastineau 2025-05-05 08:10:46 -07:00 committed by GitHub
parent eca0730607
commit eaedc6fda3
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
packages/playwright/src/runner/testServer.ts
View File

@ -16,10 +16,11 @@
import fs from 'fs'; import fs from 'fs';
import path from 'path'; import path from 'path';
import util from 'util';
import { installRootRedirect, openTraceInBrowser, openTraceViewerApp, registry, startTraceViewerServer } from 'playwright-core/lib/server'; import { installRootRedirect, openTraceInBrowser, openTraceViewerApp, registry, startTraceViewerServer } from 'playwright-core/lib/server';
import { ManualPromise, isUnderTest, gracefullyProcessExitDoNotHang } from 'playwright-core/lib/utils'; import { ManualPromise, isUnderTest, gracefullyProcessExitDoNotHang } from 'playwright-core/lib/utils';
import { open } from 'playwright-core/lib/utilsBundle'; import { open, debug } from 'playwright-core/lib/utilsBundle';
import { createErrorCollectingReporter, createReporterForTestServer, createReporters } from './reporters'; import { createErrorCollectingReporter, createReporterForTestServer, createReporters } from './reporters';
import { SigIntWatcher } from './sigIntWatcher'; import { SigIntWatcher } from './sigIntWatcher';
@ -44,6 +45,7 @@ import type { ReporterV2 } from '../reporters/reporterV2';
import type { TraceViewerRedirectOptions, TraceViewerServerOptions } from 'playwright-core/lib/server/trace/viewer/traceViewer'; import type { TraceViewerRedirectOptions, TraceViewerServerOptions } from 'playwright-core/lib/server/trace/viewer/traceViewer';
import type { HttpServer, Transport } from 'playwright-core/lib/utils'; import type { HttpServer, Transport } from 'playwright-core/lib/utils';
const originalDebugLog = debug.log;
const originalStdoutWrite = process.stdout.write; const originalStdoutWrite = process.stdout.write;
const originalStderrWrite = process.stderr.write; const originalStderrWrite = process.stderr.write;
@ -387,6 +389,13 @@ export class TestServerDispatcher implements TestServerInterface {
if (process.env.PWTEST_DEBUG) if (process.env.PWTEST_DEBUG)
return; return;
if (intercept) { if (intercept) {
if (debug.log === originalDebugLog) {
// Only if debug.log hasn't already been tampered with, don't intercept any DEBUG=* logging
debug.log = (...args) => {
const string = util.format(...args) + '\n';
return (originalStderrWrite as any).apply(process.stderr, [string]);
};
}
process.stdout.write = (chunk: string | Buffer) => { process.stdout.write = (chunk: string | Buffer) => {
this._dispatchEvent('stdio', chunkToPayload('stdout', chunk)); this._dispatchEvent('stdio', chunkToPayload('stdout', chunk));
return true; return true;
@ -396,6 +405,7 @@ export class TestServerDispatcher implements TestServerInterface {
return true; return true;
}; };
} else { } else {
debug.log = originalDebugLog;
process.stdout.write = originalStdoutWrite; process.stdout.write = originalStdoutWrite;
process.stderr.write = originalStderrWrite; process.stderr.write = originalStderrWrite;
} }