From eb7b4dea0debd6c752313f10ffdb1db676c89cd8 Mon Sep 17 00:00:00 2001 From: Andrey Lushnikov Date: Wed, 12 May 2021 13:11:59 -0700 Subject: [PATCH] tests: disable certain installation tests on Node v16 (#6544) NPM7 that comes with Node v16 swallows output from installation scripts, so certain tests don't work. --- .../installation-tests/installation-tests.sh | 17 +++++++++++------ 1 file changed, 11 insertions(+), 6 deletions(-) diff --git a/packages/installation-tests/installation-tests.sh b/packages/installation-tests/installation-tests.sh index 8fc9039a86..d880bb07e6 100755 --- a/packages/installation-tests/installation-tests.sh +++ b/packages/installation-tests/installation-tests.sh @@ -57,15 +57,9 @@ function copy_test_scripts { function run_tests { test_screencast test_typescript_types - test_skip_browser_download - test_skip_browser_download_inspect_with_custom_executable test_playwright_global_installation_subsequent_installs - test_playwright_should_work test_playwright_should_work_with_relative_home_path test_playwright_should_work_with_relative_browsers_path - test_playwright_chromium_should_work - test_playwright_webkit_should_work - test_playwright_firefox_should_work test_playwright_validate_dependencies test_playwright_validate_dependencies_skip_executable_path test_playwright_global_installation @@ -77,6 +71,17 @@ function run_tests { test_playwright_cli_install_should_work test_playwright_cli_codegen_should_work test_playwright_driver_should_work + # npm v7 that comes with Node v16 swallows output from install scripts, + # so the following tests won't work. + # See discussion at https://github.com/npm/cli/issues/1651 + if [[ "${NODE_VERSION}" != *"v16."* ]]; then + test_skip_browser_download + test_skip_browser_download_inspect_with_custom_executable + test_playwright_should_work + test_playwright_chromium_should_work + test_playwright_webkit_should_work + test_playwright_firefox_should_work + fi } function test_screencast {