yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

tests: disable certain installation tests on Node v16 (#6544)

Browse Source 
NPM7 that comes with Node v16 swallows output from installation
scripts, so certain tests don't work.
This commit is contained in:
Andrey Lushnikov 2021-05-12 13:11:59 -07:00 committed by GitHub
parent d627376147
commit eb7b4dea0d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
packages/installation-tests/installation-tests.sh
View File

@ -57,15 +57,9 @@ function copy_test_scripts {
function run_tests {
test_screencast
test_typescript_types
test_skip_browser_download
test_skip_browser_download_inspect_with_custom_executable
test_playwright_global_installation_subsequent_installs
test_playwright_should_work
test_playwright_should_work_with_relative_home_path
test_playwright_should_work_with_relative_browsers_path
test_playwright_chromium_should_work
test_playwright_webkit_should_work
test_playwright_firefox_should_work
test_playwright_validate_dependencies
test_playwright_validate_dependencies_skip_executable_path
test_playwright_global_installation
@ -77,6 +71,17 @@ function run_tests {
test_playwright_cli_install_should_work
test_playwright_cli_codegen_should_work
test_playwright_driver_should_work
# npm v7 that comes with Node v16 swallows output from install scripts,
# so the following tests won't work.
# See discussion at https://github.com/npm/cli/issues/1651
if [[ "${NODE_VERSION}" != *"v16."* ]]; then
test_skip_browser_download
test_skip_browser_download_inspect_with_custom_executable
test_playwright_should_work
test_playwright_chromium_should_work
test_playwright_webkit_should_work
test_playwright_firefox_should_work
fi
}
function test_screencast {