From f064fb68404ee021f91de3cb460d2dda6bdce45b Mon Sep 17 00:00:00 2001 From: Playwright Service <89237858+playwrightmachine@users.noreply.github.com> Date: Tue, 19 Sep 2023 00:31:58 -0700 Subject: [PATCH] feat(firefox-beta): roll to r1425 (#27128) Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Andrey Lushnikov --- packages/playwright-core/browsers.json | 4 ++-- tests/page/page-keyboard.spec.ts | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/playwright-core/browsers.json b/packages/playwright-core/browsers.json index 0641f75207..a9225c43af 100644 --- a/packages/playwright-core/browsers.json +++ b/packages/playwright-core/browsers.json @@ -33,9 +33,9 @@ }, { "name": "firefox-beta", - "revision": "1422", + "revision": "1425", "installByDefault": false, - "browserVersion": "116.0b2" + "browserVersion": "118.0b5" }, { "name": "webkit", diff --git a/tests/page/page-keyboard.spec.ts b/tests/page/page-keyboard.spec.ts index 1a312c46e5..07897d4a92 100644 --- a/tests/page/page-keyboard.spec.ts +++ b/tests/page/page-keyboard.spec.ts @@ -358,7 +358,7 @@ it('should support MacOS shortcuts', async ({ page, server, platform, browserNam expect(await page.$eval('textarea', textarea => textarea.value)).toBe('some '); }); -it('should press the meta key', async ({ page, browserName, isMac }) => { +it('should press the meta key', async ({ page, browserName, isMac, browserMajorVersion }) => { const lastEvent = await captureLastKeydown(page); await page.keyboard.press('Meta'); const { key, code, metaKey } = await lastEvent.jsonValue(); @@ -367,7 +367,7 @@ it('should press the meta key', async ({ page, browserName, isMac }) => { else expect(key).toBe('Meta'); - if (browserName === 'firefox') + if (browserName === 'firefox' && browserMajorVersion <= 117) expect(code).toBe('OSLeft'); else expect(code).toBe('MetaLeft');