From f10d0a8a58e4ae1bcb5833cd1d5f5fc3f6f828d8 Mon Sep 17 00:00:00 2001 From: Andrey Lushnikov Date: Fri, 19 Feb 2021 20:18:23 -0800 Subject: [PATCH] devops: do not create non-removable folders on windows (#5533) This fixes a bug where the script was creating a folder with a new line symbol in its name. As a result, Windows was failing to remove this folder, and Chromium Windows BuildBot was failing to even initialize checkout. --- browser_patches/chromium/archive.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/browser_patches/chromium/archive.sh b/browser_patches/chromium/archive.sh index 7297c8b60e..915058b0fe 100755 --- a/browser_patches/chromium/archive.sh +++ b/browser_patches/chromium/archive.sh @@ -127,7 +127,7 @@ function archive_compiled_chromium() { for ((i = 0; i < ${#CHROMIUM_FILES_TO_ARCHIVE[@]}; i++)) do file="${CHROMIUM_FILES_TO_ARCHIVE[$i]}" - mkdir -p "output/${CHROMIUM_FOLDER_NAME}/$(dirname $file)" + mkdir -p "output/${CHROMIUM_FOLDER_NAME}/$(dirname "${file}")" $COPY_COMMAND "${CR_CHECKOUT_PATH}/src/out/Default/${file}" "output/${CHROMIUM_FOLDER_NAME}/${file}" done