yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(trace-viewer): restore action error icon (#8163)

Browse Source 
Fixes #8051
This commit is contained in:
Pavel Feldman 2021-08-12 08:41:34 -07:00 committed by GitHub
parent 819287cc0e
commit f3b35b2bbd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/web/traceViewer/ui/actionList.css
View File

@ -106,7 +106,11 @@
color: var(--blue); color: var(--blue);
} }
.action-entry .codicon-error { .action-entry .codicon {
padding: 0 2px;
}
.action-entry .codicon-error, .action-entry .codicon-issues {
color: red; color: red;
} }

2
src/web/traceViewer/ui/actionList.tsx
View File

@ -75,6 +75,7 @@ export const ActionList: React.FC<ActionListProps> = ({
const { metadata } = action; const { metadata } = action;
const selectedSuffix = action === selectedAction ? ' selected' : ''; const selectedSuffix = action === selectedAction ? ' selected' : '';
const highlightedSuffix = action === highlightedAction ? ' highlighted' : ''; const highlightedSuffix = action === highlightedAction ? ' highlighted' : '';
const error = metadata.error?.error?.message;
const { errors, warnings } = modelUtil.stats(action); const { errors, warnings } = modelUtil.stats(action);
return <div return <div
className={'action-entry' + selectedSuffix + highlightedSuffix} className={'action-entry' + selectedSuffix + highlightedSuffix}
@ -92,6 +93,7 @@ export const ActionList: React.FC<ActionListProps> = ({
{!!errors && <div className='action-icon'><span className={'codicon codicon-error'}></span><span className="action-icon-value">{errors}</span></div>} {!!errors && <div className='action-icon'><span className={'codicon codicon-error'}></span><span className="action-icon-value">{errors}</span></div>}
{!!warnings && <div className='action-icon'><span className={'codicon codicon-warning'}></span><span className="action-icon-value">{warnings}</span></div>} {!!warnings && <div className='action-icon'><span className={'codicon codicon-warning'}></span><span className="action-icon-value">{warnings}</span></div>}
</div> </div>
{error && <div className='codicon codicon-issues' title={error} />}
</div>; </div>;
})} })}
</div> </div>