yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: handle not.toPass() with expect.soft inside (#20596)

Browse Source 
Fixes #20518
This commit is contained in:
Andrey Lushnikov 2023-02-03 09:14:05 -08:00 committed by GitHub
parent ffb719385b
commit f45f20a8c9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 20 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
packages/playwright-test/src/matchers/matchers.ts
View File

@ -352,5 +352,7 @@ export async function toPass(
return { message, pass: this.isNot }; return { message, pass: this.isNot };
} }
if (testStateBeforeToPassMatcher && testInfo)
testInfo._restoreErrorState(testStateBeforeToPassMatcher);
return { pass: !this.isNot, message: () => '' }; return { pass: !this.isNot, message: () => '' };
} }

18
tests/playwright-test/expect-to-pass.spec.ts
View File

@ -183,6 +183,24 @@ test('should swallow all soft errors inside toPass matcher, if successful', asyn
expect(result.failed).toBe(1); expect(result.failed).toBe(1);
}); });
test('should work with no.toPass and failing soft assertion', async ({ runInlineTest }) => {
test.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/20518' });
const result = await runInlineTest({
'a.spec.ts': `
const { test } = pwt;
test('should work', async () => {
await test.expect(() => {
expect.soft(1).toBe(2);
}).not.toPass({ timeout: 1000 });
});
`
});
expect(result.exitCode).toBe(0);
expect(result.failed).toBe(0);
expect(result.passed).toBe(1);
});
test('should show only soft errors on last toPass pass', async ({ runInlineTest }) => { test('should show only soft errors on last toPass pass', async ({ runInlineTest }) => {
const result = await runInlineTest({ const result = await runInlineTest({
'a.spec.ts': ` 'a.spec.ts': `