From f4b8ff9c95e3288c38f44bb8ff9f25eb9e5c5a73 Mon Sep 17 00:00:00 2001 From: Max Schmitt Date: Mon, 29 Jan 2024 20:13:54 +0100 Subject: [PATCH] fix: don't use git status for workspace consistency (#29224) Motivation: We verify this already in the [infra.yml](https://github.com/microsoft/playwright/blob/main/.github/workflows/infra.yml). Doing it in `workspace.js` breaks the canary builds, because it has stray files (package.json / package-lock.json). --- utils/workspace.js | 4 ---- 1 file changed, 4 deletions(-) diff --git a/utils/workspace.js b/utils/workspace.js index 9e813414eb..f1e2aaa4d9 100755 --- a/utils/workspace.js +++ b/utils/workspace.js @@ -236,10 +236,6 @@ async function parseCLI() { const hasChanges = await workspace.ensureConsistent(); if (hasChanges) die(`\n ERROR: workspace is inconsistent! Run '//utils/workspace.js --ensure-consistent' and commit changes!`); - // check that there are no dirty git files. - const gitStatus = child_process.execSync('git status --porcelain').toString(); - if (gitStatus.trim()) - die(`\n ERROR: some git files are dirty, run build and commit changes!\n${gitStatus}`); // Ensure lockfileVersion is 3 const packageLock = require(ROOT_PATH + '/package-lock.json'); if (packageLock.lockfileVersion !== 3)