yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(test runner): default workerIndex to -1 (#13440)

Browse Source
This commit is contained in:
Dmitry Gozman 2022-04-08 15:23:23 -07:00 committed by GitHub
parent 9712b9ee08
commit f6ccd4847e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
docs/src/test-reporter-api/class-testresult.md
View File

@ -63,6 +63,6 @@ List of steps inside this test run.
## property: TestResult.workerIndex ## property: TestResult.workerIndex
- type: <[int]> - type: <[int]>
Index of the worker where the test was run. Index of the worker where the test was run. If the test was not run a single time, for example when the user interrupted testing, the only result will have a `workerIndex` equal to `-1`.
Learn more about [parallelism and sharding](../test-parallel.md) with Playwright Test. Learn more about [parallelism and sharding](../test-parallel.md) with Playwright Test.

2
packages/playwright-test/src/test.ts
View File

@ -176,7 +176,7 @@ export class TestCase extends Base implements reporterTypes.TestCase {
_appendTestResult(): reporterTypes.TestResult { _appendTestResult(): reporterTypes.TestResult {
const result: reporterTypes.TestResult = { const result: reporterTypes.TestResult = {
retry: this.results.length, retry: this.results.length,
workerIndex: 0, workerIndex: -1,
duration: 0, duration: 0,
startTime: new Date(), startTime: new Date(),
stdout: [], stdout: [],

3
packages/playwright-test/types/testReporter.d.ts vendored
View File

@ -293,7 +293,8 @@ export interface TestResult {
steps: Array<TestStep>; steps: Array<TestStep>;
/** /**
* Index of the worker where the test was run. * Index of the worker where the test was run. If the test was not run a single time, for example when the user interrupted
* testing, the only result will have a `workerIndex` equal to `-1`.
* *
* Learn more about [parallelism and sharding](https://playwright.dev/docs/test-parallel) with Playwright Test. * Learn more about [parallelism and sharding](https://playwright.dev/docs/test-parallel) with Playwright Test.
*/ */

8
tests/playwright-test/runner.spec.ts
View File

@ -110,6 +110,14 @@ test('sigint should stop workers', async ({ runInlineTest }) => {
expect(result.output).toContain('%%SEND-SIGINT%%2'); expect(result.output).toContain('%%SEND-SIGINT%%2');
expect(result.output).not.toContain('%%skipped1'); expect(result.output).not.toContain('%%skipped1');
expect(result.output).not.toContain('%%skipped2'); expect(result.output).not.toContain('%%skipped2');
const interrupted2 = result.report.suites[1].specs[0];
expect(interrupted2.title).toBe('interrupted2');
expect(interrupted2.tests[0].results[0].workerIndex === 0 || interrupted2.tests[0].results[0].workerIndex === 1).toBe(true);
const skipped2 = result.report.suites[1].specs[1];
expect(skipped2.title).toBe('skipped2');
expect(skipped2.tests[0].results[0].workerIndex).toBe(-1);
}); });
test('should use the first occurring error when an unhandled exception was thrown', async ({ runInlineTest }) => { test('should use the first occurring error when an unhandled exception was thrown', async ({ runInlineTest }) => {