yujunjun/playwright
1
0
Fork 0
mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat(firefox): bump to 1204, add a better test for video in popup (#4376)

Browse Source
This commit is contained in:
Dmitry Gozman 2020-11-07 18:21:26 -08:00 committed by GitHub
parent 28f6547d67
commit f7eb845df0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 31 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
browsers.json
View File

@ -8,7 +8,7 @@
}, },
{ {
"name": "firefox", "name": "firefox",
"revision": "1203", "revision": "1204",
"download": true "download": true
}, },
{ {

53
test/screencast.spec.ts
View File

@ -135,6 +135,24 @@ function findVideos(videoDir: string) {
return files.filter(file => file.endsWith('webm')).map(file => path.join(videoDir, file)); return files.filter(file => file.endsWith('webm')).map(file => path.join(videoDir, file));
} }
function expectRedFrames(videoFile: string, size: { width: number, height: number }) {
const videoPlayer = new VideoPlayer(videoFile);
const duration = videoPlayer.duration;
expect(duration).toBeGreaterThan(0);
expect(videoPlayer.videoWidth).toBe(size.width);
expect(videoPlayer.videoHeight).toBe(size.height);
{
const pixels = videoPlayer.seekLastFrame().data;
expectAll(pixels, almostRed);
}
{
const pixels = videoPlayer.seekLastFrame({ x: size.width - 20, y: 0 }).data;
expectAll(pixels, almostRed);
}
}
describe('screencast', suite => { describe('screencast', suite => {
suite.slow(); suite.slow();
}, () => { }, () => {
@ -158,12 +176,7 @@ describe('screencast', suite => {
await context.close(); await context.close();
const videoFile = await page.video().path(); const videoFile = await page.video().path();
const videoPlayer = new VideoPlayer(videoFile); expectRedFrames(videoFile, size);
const duration = videoPlayer.duration;
expect(duration).toBeGreaterThan(0);
expect(videoPlayer.videoWidth).toBe(450);
expect(videoPlayer.videoHeight).toBe(240);
}); });
it('should throw without recordVideo.dir', async ({ browser }) => { it('should throw without recordVideo.dir', async ({ browser }) => {
@ -187,21 +200,7 @@ describe('screencast', suite => {
await context.close(); await context.close();
const videoFile = await page.video().path(); const videoFile = await page.video().path();
const videoPlayer = new VideoPlayer(videoFile); expectRedFrames(videoFile, size);
const duration = videoPlayer.duration;
expect(duration).toBeGreaterThan(0);
expect(videoPlayer.videoWidth).toBe(450);
expect(videoPlayer.videoHeight).toBe(240);
{
const pixels = videoPlayer.seekLastFrame().data;
expectAll(pixels, almostRed);
}
{
const pixels = videoPlayer.seekLastFrame({ x: 430, y: 0}).data;
expectAll(pixels, almostRed);
}
}); });
it('should expose video path', async ({browser, testInfo}) => { it('should expose video path', async ({browser, testInfo}) => {
@ -322,22 +321,30 @@ describe('screencast', suite => {
it('should work for popups', async ({browser, testInfo, server}) => { it('should work for popups', async ({browser, testInfo, server}) => {
const videosPath = testInfo.outputPath(''); const videosPath = testInfo.outputPath('');
const size = { width: 450, height: 240 };
const context = await browser.newContext({ const context = await browser.newContext({
recordVideo: { recordVideo: {
dir: videosPath, dir: videosPath,
size: { width: 320, height: 240 } size,
}, },
viewport: size,
}); });
const page = await context.newPage(); const page = await context.newPage();
await page.goto(server.EMPTY_PAGE); await page.goto(server.EMPTY_PAGE);
await Promise.all([ const [popup] = await Promise.all([
page.waitForEvent('popup'), page.waitForEvent('popup'),
page.evaluate(() => { window.open('about:blank'); }), page.evaluate(() => { window.open('about:blank'); }),
]); ]);
await popup.evaluate(() => document.body.style.backgroundColor = 'red');
await new Promise(r => setTimeout(r, 1000)); await new Promise(r => setTimeout(r, 1000));
await context.close(); await context.close();
const pageVideoFile = await page.video().path();
const popupVideoFile = await popup.video().path();
expect(pageVideoFile).not.toEqual(popupVideoFile);
expectRedFrames(popupVideoFile, size);
const videoFiles = findVideos(videosPath); const videoFiles = findVideos(videosPath);
expect(videoFiles.length).toBe(2); expect(videoFiles.length).toBe(2);
}); });