From fc8f0101c8890e1932a7bbe5494be085f9daa9d3 Mon Sep 17 00:00:00 2001 From: Dmitriy Dudkevich Date: Fri, 16 Jun 2023 12:44:04 +0300 Subject: [PATCH] fix(selenium): send additional headers to delete session method (#23719) In the process of completing the task - https://github.com/microsoft/playwright/pull/23348, I didn't notice the need to pass headers to the session deletion method. So I fixed it here. And support headers for selenium@3. --- packages/playwright-core/src/server/chromium/chromium.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/packages/playwright-core/src/server/chromium/chromium.ts b/packages/playwright-core/src/server/chromium/chromium.ts index 80a8deaa86..f4d9ec0100 100644 --- a/packages/playwright-core/src/server/chromium/chromium.ts +++ b/packages/playwright-core/src/server/chromium/chromium.ts @@ -216,6 +216,7 @@ export class Chromium extends BrowserType { await fetchData({ url: hubUrl + 'session/' + sessionId, method: 'DELETE', + headers, }).catch(error => progress.log(`: ${error}`)); progress.log(` disconnected from sessionId=${sessionId}`); gracefullyCloseSet.delete(disconnectFromSelenium); @@ -252,6 +253,7 @@ export class Chromium extends BrowserType { url: sessionInfoUrl, method: 'GET', timeout: progress.timeUntilDeadline(), + headers, }, seleniumErrorHandler); const proxyId = JSON.parse(sessionResponse).proxyId; endpointURL.hostname = new URL(proxyId).hostname;