test: use custom header when testing header removal (#4157)

This commit is contained in:
Yury Semikhatsky 2020-10-15 10:31:07 -07:00 committed by GitHub
parent 8f8bebb632
commit fec37adf68
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -96,24 +96,20 @@ it('should work when header manipulation headers with redirect', async ({page, s
await page.goto(server.PREFIX + '/rrredirect'); await page.goto(server.PREFIX + '/rrredirect');
}); });
// @see https://github.com/GoogleChrome/puppeteer/issues/4743 // @see https://github.com/GoogleChrome/puppeteer/issues/4743
it('should be able to remove headers', (test, {browserName}) => { it('should be able to remove headers', async ({page, server}) => {
// On WebKit the accept header gets set to "*/*" await page.goto(server.EMPTY_PAGE);
test.fail(browserName === 'webkit');
}, async ({page, server}) => {
await page.route('**/*', route => { await page.route('**/*', route => {
const headers = Object.assign({}, route.request().headers(), { const headers = Object.assign({}, route.request().headers(), {
foo: 'bar', foo: undefined, // remove "foo" header
accept: undefined, // remove "accept" header
}); });
route.continue({ headers }); route.continue({ headers });
}); });
const [serverRequest] = await Promise.all([ const [serverRequest] = await Promise.all([
server.waitForRequest('/empty.html'), server.waitForRequest('/title.html'),
page.goto(server.PREFIX + '/empty.html') page.evaluate(url => fetch(url, { headers: {foo: 'bar'} }), server.PREFIX + '/title.html')
]); ]);
expect(serverRequest.headers.foo).toBe(undefined);
expect(serverRequest.headers.accept).toBe(undefined);
}); });
it('should contain referer header', async ({page, server}) => { it('should contain referer header', async ({page, server}) => {