Pavel Feldman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							61a1924328 
							
						 
					 
					
						
						
							
							chore: align recorder drawer with trace viewer ( #26922 )  
						
						
						
						
					 
					
						2023-09-06 17:13:25 -07:00 
						 
				 
			
				
					
						
							
							
								Andrey Lushnikov 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							0bb4dac28f 
							
						 
					 
					
						
						
							
							tests: fix race condition in codegen tests ( #26405 )  
						
						... 
						
						
						
						The console message comes in once the page navigates, not in the
`page.setContent()` call below. 
						
						
					 
					
						2023-08-10 07:51:38 -07:00 
						 
				 
			
				
					
						
							
							
								Pavel Feldman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							b39fd7283f 
							
						 
					 
					
						
						
							
							chore: skip tests that fail in cross-machine service mode ( #24412 )  
						
						
						
						
					 
					
						2023-07-25 16:47:04 -07:00 
						 
				 
			
				
					
						
							
							
								Max Schmitt 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							0f9f863183 
							
						 
					 
					
						
						
							
							fix(codegen): generate no Enter keyboard events for textareas ( #23775 )  
						
						... 
						
						
						
						Fixes https://github.com/microsoft/playwright/issues/23774  
						
						
					 
					
						2023-06-19 17:07:37 +02:00 
						 
				 
			
				
					
						
							
							
								Dmitry Gozman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							4f8680f7a3 
							
						 
					 
					
						
						
							
							fix(pause): revert timeouts after pause ( #23578 )  
						
						... 
						
						
						
						Fixes  #23523 . 
					
						2023-06-07 12:30:10 -07:00 
						 
				 
			
				
					
						
							
							
								Max Schmitt 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							3c2a8fa306 
							
						 
					 
					
						
						
							
							chore: enable no-floating-promises ESLint rule for tests ( #23376 )  
						
						... 
						
						
						
						https://github.com/microsoft/playwright/issues/23339  
					
						2023-06-02 21:59:12 +02:00 
						 
				 
			
				
					
						
							
							
								Pavel Feldman 
							
						 
					 
					
						
						
						
						
							
						
						
							fd75b85510 
							
						 
					 
					
						
						
							
							Revert "chore: more tree gardening ( #23119 )"  
						
						... 
						
						
						
						This reverts commit e6bc32b0222d628db6191602ff85ff9801a5a7ec. 
						
						
					 
					
						2023-05-23 12:04:44 -07:00 
						 
				 
			
				
					
						
							
							
								Pavel Feldman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							631edc9744 
							
						 
					 
					
						
						
							
							chore(internal): generate code in jsonl ( #23124 )  
						
						
						
						
					 
					
						2023-05-20 10:15:33 -07:00 
						 
				 
			
				
					
						
							
							
								Andrey Lushnikov 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							e6bc32b022 
							
						 
					 
					
						
						
							
							chore: more tree gardening ( #23119 )  
						
						... 
						
						
						
						https://github.com/microsoft/playwright/issues/23114 
https://github.com/microsoft/playwright/issues/23115 
https://github.com/microsoft/playwright/issues/23116 
https://github.com/microsoft/playwright/issues/23117 
https://github.com/microsoft/playwright/issues/23118  
					
						2023-05-17 18:57:35 -07:00 
						 
				 
			
				
					
						
							
							
								Dmitry Gozman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							62146b946c 
							
						 
					 
					
						
						
							
							fix(codegen): ignore previously hovered detached nodes ( #23057 )  
						
						... 
						
						
						
						Fixes  #23043 . 
					
						2023-05-16 11:13:19 -07:00 
						 
				 
			
				
					
						
							
							
								Dmitry Gozman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							160888df99 
							
						 
					 
					
						
						
							
							feat(locators): reland locator.and(locator) ( #22850 )  
						
						... 
						
						
						
						Removed in #22223 .
Fixes  #22585 . 
						
						
					 
					
						2023-05-05 11:14:01 -07:00 
						 
				 
			
				
					
						
							
							
								Pavel Feldman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							116fb349ce 
							
						 
					 
					
						
						
							
							chore: allow configuring test id attribute for codegen ( #22716 )  
						
						... 
						
						
						
						Fixes: https://github.com/microsoft/playwright/issues/22653  
						
						
					 
					
						2023-04-29 12:04:33 -07:00 
						 
				 
			
				
					
						
							
							
								Andrey Lushnikov 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							2977c2b539 
							
						 
					 
					
						
						
							
							test: refer to the upstream Firefox bug ( #22364 )  
						
						... 
						
						
						
						There's no action on our side to fix this.
Fixes https://github.com/microsoft/playwright/issues/21550  
						
						
					 
					
						2023-04-12 10:37:21 -07:00 
						 
				 
			
				
					
						
							
							
								Andrey Lushnikov 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							8bb708be70 
							
						 
					 
					
						
						
							
							test: unflake inspector-cli tests ( #22347 )  
						
						... 
						
						
						
						This patch:
- changes the `childProcess` fixture to reliably SIGKILL all descendants
  (children and grand-children, regardless of their process group).
This is achieved using the `ps` command to build the process tree, and
then send
  `SIGKILL` to the descendant process groups.
- changes the `runCLI` fixture to **not** auto-close codegen by default;
  the `childProcess` fixture will clean up all processes. This makes
sure that all `runCLI.waitFor()` commands actually wait until the
necessary
  output.
- for a handful of tests that do actually want to auto-close codegen,
  introduce an optional `autoCloseWhen` flag for the `runCLI` fixture
that makes sure to close the codegen once a certain output was reached. 
						
						
					 
					
						2023-04-12 09:37:24 -07:00 
						 
				 
			
				
					
						
							
							
								Max Schmitt 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							2df0f0738d 
							
						 
					 
					
						
						
							
							test: report and kill child processes which are leaking after test ( #22237 )  
						
						
						
						
					 
					
						2023-04-06 20:09:19 +02:00 
						 
				 
			
				
					
						
							
							
								Dmitry Gozman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							08cef43e82 
							
						 
					 
					
						
						
							
							feat(locator): remove locator.and and locator.not ( #22223 )  
						
						... 
						
						
						
						Not shipping for now, after API review. 
						
						
					 
					
						2023-04-05 16:28:13 -07:00 
						 
				 
			
				
					
						
							
							
								Dmitry Gozman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							35afb056ea 
							
						 
					 
					
						
						
							
							feat(locator): filter({ hasNotText }) ( #22222 )  
						
						... 
						
						
						
						The opposite of `filter({ hasText })`. 
						
						
					 
					
						2023-04-05 14:13:28 -07:00 
						 
				 
			
				
					
						
							
							
								Dmitry Gozman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							bc1de5f28d 
							
						 
					 
					
						
						
							
							feat(locator): filter({ hasNot }) ( #22219 )  
						
						... 
						
						
						
						This is the opposite of `filter({ has })`. 
						
						
					 
					
						2023-04-05 12:45:46 -07:00 
						 
				 
			
				
					
						
							
							
								Dmitry Gozman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							539d9873c2 
							
						 
					 
					
						
						
							
							feat: rename Locator.filter(locator) to Locator.and ( #22101 )  
						
						
						
						
					 
					
						2023-03-30 14:41:30 -07:00 
						 
				 
			
				
					
						
							
							
								Dmitry Gozman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							e6148bb725 
							
						 
					 
					
						
						
							
							feat: Locator.not(locator) ( #22066 )  
						
						
						
						
					 
					
						2023-03-30 08:52:30 -07:00 
						 
				 
			
				
					
						
							
							
								Pavel Feldman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							968abd27d5 
							
						 
					 
					
						
						
							
							chore: do not use attributes for trace target annotation ( #22075 )  
						
						... 
						
						
						
						Fixes: https://github.com/microsoft/playwright/issues/22004  
						
						
					 
					
						2023-03-29 23:17:17 -07:00 
						 
				 
			
				
					
						
							
							
								Dmitry Gozman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							525097d465 
							
						 
					 
					
						
						
							
							feat: Locator.filter(locator) ( #21975 )  
						
						... 
						
						
						
						Produces a locator that matches both locators.
Implemented through `internal:and` selector.
Fixes  #19551 . 
						
						
					 
					
						2023-03-27 14:29:30 -07:00 
						 
				 
			
				
					
						
							
							
								Dmitry Gozman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							d10fac4f6a 
							
						 
					 
					
						
						
							
							feat: Locator.or(locator) ( #21884 )  
						
						
						
						
					 
					
						2023-03-22 15:28:59 -07:00 
						 
				 
			
				
					
						
							
							
								Pavel Feldman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							e45a496850 
							
						 
					 
					
						
						
							
							chore(tv): render error in-line ( #21586 )  
						
						
						
						
					 
					
						2023-03-10 16:22:19 -08:00 
						 
				 
			
				
					
						
							
							
								Andrey Lushnikov 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							7a1c5b2aa3 
							
						 
					 
					
						
						
							
							test: make the tree green ( #21551 )  
						
						... 
						
						
						
						References https://github.com/microsoft/playwright/issues/20522 
References https://github.com/microsoft/playwright/issues/20993 
References https://github.com/microsoft/playwright/issues/21435 
References https://github.com/microsoft/playwright/issues/21512 
References https://github.com/microsoft/playwright/issues/21549 
References https://github.com/microsoft/playwright/issues/21550  
						
						
					 
					
						2023-03-09 16:56:29 -08:00 
						 
				 
			
				
					
						
							
							
								Dmitry Gozman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							821949d580 
							
						 
					 
					
						
						
							
							test: update stale test expectations ( #20423 )  
						
						
						
						
					 
					
						2023-01-27 21:52:34 -08:00 
						 
				 
			
				
					
						
							
							
								Max Schmitt 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							a7495c3326 
							
						 
					 
					
						
						
							
							fix: use no internal selectors for frame locators ( #19964 )  
						
						... 
						
						
						
						Fixes https://github.com/microsoft/playwright/issues/19406  
						
						
					 
					
						2023-01-11 21:53:19 +01:00 
						 
				 
			
				
					
						
							
							
								Dmitry Gozman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							f58015281a 
							
						 
					 
					
						
						
							
							test: attempt to unflake inspector tests ( #19845 )  
						
						... 
						
						
						
						On headed bots, we might get `locator('body')` from initial mouse
position. 
						
						
					 
					
						2023-01-03 16:26:21 -08:00 
						 
				 
			
				
					
						
							
							
								Dmitry Gozman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							1bb019ac81 
							
						 
					 
					
						
						
							
							chore: migrate most of rerunnable tasks to element callback ( #19713 )  
						
						
						
						
					 
					
						2022-12-27 09:22:22 -08:00 
						 
				 
			
				
					
						
							
							
								Dmitry Gozman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							1263bc3edd 
							
						 
					 
					
						
						
							
							feat(console api): first/last/nth ( #19485 )  
						
						
						
						
					 
					
						2022-12-15 11:17:59 -08:00 
						 
				 
			
				
					
						
							
							
								Dmitry Gozman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							3c17a2603a 
							
						 
					 
					
						
						
							
							feat(console api): support locator.filter ( #19389 )  
						
						
						
						
					 
					
						2022-12-09 15:25:12 -08:00 
						 
				 
			
				
					
						
							
							
								Dmitry Gozman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							0be4fa768a 
							
						 
					 
					
						
						
							
							fix(codegen): do not generate Promise.all ( #19182 )  
						
						... 
						
						
						
						Drive-by: fix `download`, `dialog` and `popup` signals to use different
variable names in all languages. 
						
						
					 
					
						2022-12-02 17:33:01 -08:00 
						 
				 
			
				
					
						
							
							
								Dmitry Gozman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							c547416e24 
							
						 
					 
					
						
						
							
							test: unflake "should highlight locators with custom testId" ( #19236 )  
						
						
						
						
					 
					
						2022-12-02 17:32:29 -08:00 
						 
				 
			
				
					
						
							
							
								Max Schmitt 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							3565d97a36 
							
						 
					 
					
						
						
							
							feat(recorder): make it work with [contenteditable] ( #19066 )  
						
						... 
						
						
						
						https://github.com/microsoft/playwright/issues/19029  
					
						2022-12-01 12:41:03 -08:00 
						 
				 
			
				
					
						
							
							
								Dmitry Gozman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							307a0b6ea7 
							
						 
					 
					
						
						
							
							fix(dotnet): codegen/docs use Name instead of NameString ( #19156 )  
						
						
						
						
					 
					
						2022-11-29 20:56:18 -08:00 
						 
				 
			
				
					
						
							
							
								Dmitry Gozman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							43a6bf4d45 
							
						 
					 
					
						
						
							
							fix(inspector): support custom test id attribute ( #18996 )  
						
						... 
						
						
						
						Fixes  #18959 . 
					
						2022-11-29 11:43:47 -08:00 
						 
				 
			
				
					
						
							
							
								Dmitry Gozman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							4f72a895e9 
							
						 
					 
					
						
						
							
							fix(inspector): render expect.not correctly ( #19125 )  
						
						... 
						
						
						
						Also fixes the same in expect logs.
References #19083 . 
						
						
					 
					
						2022-11-28 20:50:16 -08:00 
						 
				 
			
				
					
						
							
							
								Pavel Feldman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							59418aa6f3 
							
						 
					 
					
						
						
							
							chore: ignore untrusted clicks when recording ( #18796 )  
						
						... 
						
						
						
						Fixes https://github.com/microsoft/playwright/issues/18776  
						
						
					 
					
						2022-11-14 15:16:25 -08:00 
						 
				 
			
				
					
						
							
							
								Max Schmitt 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							56d7d47d43 
							
						 
					 
					
						
						
							
							fix(codegen): make select work with size attribute ( #18712 )  
						
						... 
						
						
						
						Fixes https://github.com/microsoft/playwright/issues/18711  
						
						
					 
					
						2022-11-10 15:06:53 -08:00 
						 
				 
			
				
					
						
							
							
								Dmitry Gozman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							cafa558845 
							
						 
					 
					
						
						
							
							fix(codegen): update priorites in selector generator ( #18688 )  
						
						... 
						
						
						
						- prefer `role=checkbox` over `input[type=checkbox]`
- prefer `#id` over `input[type=checkbox]` and `role=checkbox`
- prefer `text=foo` over `internal:has-text=foo`
- ignore `none` and `presentation` roles
- remove non-strict support 
						
						
					 
					
						2022-11-09 17:22:13 -08:00 
						 
				 
			
				
					
						
							
							
								Dmitry Gozman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							6a65a43e9a 
							
						 
					 
					
						
						
							
							chore: use consistent asLocator() in all logs ( #18586 )  
						
						... 
						
						
						
						References #18524 . 
						
						
					 
					
						2022-11-04 15:19:16 -07:00 
						 
				 
			
				
					
						
							
							
								Pavel Feldman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							17c8554255 
							
						 
					 
					
						
						
							
							chore(recorder): explore using codemirror ( #18529 )  
						
						
						
						
					 
					
						2022-11-03 09:55:23 -07:00 
						 
				 
			
				
					
						
							
							
								Dmitry Gozman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							20f2e0049c 
							
						 
					 
					
						
						
							
							test: unflake codegen tests waiting for highlight ( #18518 )  
						
						... 
						
						
						
						Clear existing highlights to avoid resolving with the old highlight
value. 
						
						
					 
					
						2022-11-02 17:00:33 -07:00 
						 
				 
			
				
					
						
							
							
								Pavel Feldman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							2183d9e9a2 
							
						 
					 
					
						
						
							
							chore: use codemirror for editor ( #18482 )  
						
						
						
						
					 
					
						2022-11-01 15:04:30 -07:00 
						 
				 
			
				
					
						
							
							
								Pavel Feldman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							37250cde17 
							
						 
					 
					
						
						
							
							chore: switch to the new debug controller harness ( #18308 )  
						
						
						
						
					 
					
						2022-10-25 09:55:20 -07:00 
						 
				 
			
				
					
						
							
							
								Pavel Feldman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							d8ec7cba47 
							
						 
					 
					
						
						
							
							chore: don't generate new lines in codegen ( #18309 )  
						
						
						
						
					 
					
						2022-10-25 09:02:06 -07:00 
						 
				 
			
				
					
						
							
							
								Pavel Feldman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							3f850d27e9 
							
						 
					 
					
						
						
							
							fix(highlight): fix the testing harness to be real ( #18294 )  
						
						
						
						
					 
					
						2022-10-24 15:01:48 -07:00 
						 
				 
			
				
					
						
							
							
								Pavel Feldman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							84daeafb3a 
							
						 
					 
					
						
						
							
							chore: use internal locator for role ( #18187 )  
						
						
						
						
					 
					
						2022-10-19 19:38:47 -07:00 
						 
				 
			
				
					
						
							
							
								Yury Semikhatsky 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							69092b153a 
							
						 
					 
					
						
						
							
							chore(codegen): do not generate  waitForURL ( #18167 )  
						
						... 
						
						
						
						Fixes https://github.com/microsoft/playwright/issues/17179  
						
						
					 
					
						2022-10-19 11:26:19 -07:00 
						 
				 
			
				
					
						
							
							
								Pavel Feldman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							739b64a09a 
							
						 
					 
					
						
						
							
							chore: render typed locators in the recorder ( #18162 )  
						
						
						
						
					 
					
						2022-10-18 16:39:58 -07:00