Pavel Feldman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							931b9f28cd 
							
						 
					 
					
						
						
							
							fix(codegen): attribute navigation to press/fill ( #34528 )  
						
						
						
						
					 
					
						2025-01-28 17:59:16 -08:00 
						 
				 
			
				
					
						
							
							
								Yury Semikhatsky 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							00bb17751b 
							
						 
					 
					
						
						
							
							chore: delete recorder in traceviewer experiment ( #34347 )  
						
						
						
						
					 
					
						2025-01-15 17:37:33 -08:00 
						 
				 
			
				
					
						
							
							
								Simon Knott 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							4914f34a83 
							
						 
					 
					
						
						
							
							fix(recorder): allow clearing when recording is disabled ( #33821 )  
						
						
						
						
					 
					
						2024-12-06 10:17:06 -08:00 
						 
				 
			
				
					
						
							
							
								Max Schmitt 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							87624c5434 
							
						 
					 
					
						
						
							
							Revert "fix(codegen): fix unselect issue ( #32127 )" ( #33065 )  
						
						... 
						
						
						
						This reverts commit 5121b19ac618432c9203282c07d8448b4889869d.
The tree is red and fixing seems non-trivial.
Closes https://github.com/microsoft/playwright/issues/33064 
Closes https://github.com/microsoft/playwright/pull/33060  
						
						
					 
					
						2024-10-11 16:33:17 +02:00 
						 
				 
			
				
					
						
							
							
								Fumiaki MATSUSHIMA 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							5121b19ac6 
							
						 
					 
					
						
						
							
							fix(codegen): fix unselect issue ( #32127 )  
						
						... 
						
						
						
						Fixes https://github.com/microsoft/playwright/issues/31290  
						
						
					 
					
						2024-10-08 11:38:52 -07:00 
						 
				 
			
				
					
						
							
							
								Pavel Feldman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							61801aa1ee 
							
						 
					 
					
						
						
							
							chore: more codegen fixes ( #32816 )  
						
						
						
						
					 
					
						2024-09-25 18:18:36 -07:00 
						 
				 
			
				
					
						
							
							
								Pavel Feldman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							35158feec0 
							
						 
					 
					
						
						
							
							chore: fix codegen flakiness ( #32799 )  
						
						
						
						
					 
					
						2024-09-24 19:56:31 -07:00 
						 
				 
			
				
					
						
							
							
								Max Schmitt 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							5e7d7f356b 
							
						 
					 
					
						
						
							
							test: skip codegen tracing tests in PWTEST_TRACE mode ( #32788 )  
						
						
						
						
					 
					
						2024-09-24 12:35:05 +02:00 
						 
				 
			
				
					
						
							
							
								Pavel Feldman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							a00e1c9c4b 
							
						 
					 
					
						
						
							
							chore: make recorder tests match order of codegen calls ( #32716 )  
						
						
						
						
					 
					
						2024-09-19 10:31:44 -07:00 
						 
				 
			
				
					
						
							
							
								Pavel Feldman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							6dbde62a6b 
							
						 
					 
					
						
						
							
							chore: simplify signal handling while recording ( #32624 )  
						
						
						
						
					 
					
						2024-09-16 14:39:36 -07:00 
						 
				 
			
				
					
						
							
							
								Pavel Feldman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							d051495c7a 
							
						 
					 
					
						
						
							
							chore: perform double click while recording ( #32576 )  
						
						
						
						
					 
					
						2024-09-12 11:40:44 -07:00 
						 
				 
			
				
					
						
							
							
								Fumiaki MATSUSHIMA 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							838c572209 
							
						 
					 
					
						
						
							
							fix: select issue in Windows with Edge ( #31270 )  
						
						
						
						
					 
					
						2024-06-17 10:28:07 +02:00 
						 
				 
			
				
					
						
							
							
								Rui Figueira 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							c80b851422 
							
						 
					 
					
						
						
							
							fix(codegen): prevent csp directive violations ( #30366 )  
						
						
						
						
					 
					
						2024-04-23 07:33:12 -07:00 
						 
				 
			
				
					
						
							
							
								Rui Figueira 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							73ffaf65d7 
							
						 
					 
					
						
						
							
							fix(codegen): fill action prevents omnibox navigation recording ( #29790 )  
						
						... 
						
						
						
						This PR is a fix proposal for a bug when trying to record a omnibox
navigation after a recorded action (e.g., `fill`).
The following test, included in this PR, reproduces the problem:
```ts
  test('should record omnibox navigations after recordAction', async ({ page, openRecorder, server }) => {
    const recorder = await openRecorder();
    await recorder.setContentAndWait(`<textarea></textarea>`);
    await Promise.all([
      recorder.waitForOutput('JavaScript', 'fill'),
      page.locator('textarea').fill('Hello world'),
    ]);
    // for performed actions, 5 seconds is the time needed to ensure they are committed
    await page.waitForTimeout(5000);
    await page.goto(server.PREFIX + `/empty.html`);
    await recorder.waitForOutput('JavaScript', `await page.goto('${server.PREFIX}/empty.html');`);
  });
```
After performed actions (e.g., `click`), it successfully records the
navigation as long as there's at least a 5 sec. gap between both
actions. That happens because after that 5 sec. interval the performed
action is automatically commited and therefore the navigation is not
stored as a signal of that action.
The proposed fix for recorded actions also forces that action to be
automatically commited after 5 sec (for testing, I'm using 500ms to
speed up the test execution). 
						
						
					 
					
						2024-03-04 12:31:03 -08:00 
						 
				 
			
				
					
						
							
							
								Rui Figueira 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							b88a008a87 
							
						 
					 
					
						
						
							
							feat(codegen): slider support ( #29087 )  
						
						
						
						
					 
					
						2024-02-01 13:45:19 -08:00 
						 
				 
			
				
					
						
							
							
								Max Schmitt 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							e551506c9e 
							
						 
					 
					
						
						
							
							Revert "feat(codegen): add range input recording support ( #28767 )" ( #29069 )  
						
						
						
						
					 
					
						2024-01-19 19:47:59 +01:00 
						 
				 
			
				
					
						
							
							
								Rui Figueira 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							778828cc43 
							
						 
					 
					
						
						
							
							feat(codegen): add range input recording support ( #28767 )  
						
						
						
						
					 
					
						2023-12-30 17:22:57 -08:00 
						 
				 
			
				
					
						
							
							
								Max Schmitt 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							44c3ad5ceb 
							
						 
					 
					
						
						
							
							chore: make csharp library codegen more csharp like ( #28663 )  
						
						
						
						
					 
					
						2023-12-15 10:24:26 -08:00 
						 
				 
			
				
					
						
							
							
								Pavel Feldman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							5752a28f87 
							
						 
					 
					
						
						
							
							chore: make tests strict (1) ( #27731 )  
						
						
						
						
					 
					
						2023-10-23 09:31:30 -07:00 
						 
				 
			
				
					
						
							
							
								Max Schmitt 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							0f9f863183 
							
						 
					 
					
						
						
							
							fix(codegen): generate no Enter keyboard events for textareas ( #23775 )  
						
						... 
						
						
						
						Fixes https://github.com/microsoft/playwright/issues/23774  
						
						
					 
					
						2023-06-19 17:07:37 +02:00 
						 
				 
			
				
					
						
							
							
								Pavel Feldman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							968abd27d5 
							
						 
					 
					
						
						
							
							chore: do not use attributes for trace target annotation ( #22075 )  
						
						... 
						
						
						
						Fixes: https://github.com/microsoft/playwright/issues/22004  
						
						
					 
					
						2023-03-29 23:17:17 -07:00 
						 
				 
			
				
					
						
							
							
								Dmitry Gozman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							821949d580 
							
						 
					 
					
						
						
							
							test: update stale test expectations ( #20423 )  
						
						
						
						
					 
					
						2023-01-27 21:52:34 -08:00 
						 
				 
			
				
					
						
							
							
								Dmitry Gozman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							0be4fa768a 
							
						 
					 
					
						
						
							
							fix(codegen): do not generate Promise.all ( #19182 )  
						
						... 
						
						
						
						Drive-by: fix `download`, `dialog` and `popup` signals to use different
variable names in all languages. 
						
						
					 
					
						2022-12-02 17:33:01 -08:00 
						 
				 
			
				
					
						
							
							
								Max Schmitt 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							3565d97a36 
							
						 
					 
					
						
						
							
							feat(recorder): make it work with [contenteditable] ( #19066 )  
						
						... 
						
						
						
						https://github.com/microsoft/playwright/issues/19029  
					
						2022-12-01 12:41:03 -08:00 
						 
				 
			
				
					
						
							
							
								Dmitry Gozman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							307a0b6ea7 
							
						 
					 
					
						
						
							
							fix(dotnet): codegen/docs use Name instead of NameString ( #19156 )  
						
						
						
						
					 
					
						2022-11-29 20:56:18 -08:00 
						 
				 
			
				
					
						
							
							
								Pavel Feldman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							59418aa6f3 
							
						 
					 
					
						
						
							
							chore: ignore untrusted clicks when recording ( #18796 )  
						
						... 
						
						
						
						Fixes https://github.com/microsoft/playwright/issues/18776  
						
						
					 
					
						2022-11-14 15:16:25 -08:00 
						 
				 
			
				
					
						
							
							
								Max Schmitt 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							56d7d47d43 
							
						 
					 
					
						
						
							
							fix(codegen): make select work with size attribute ( #18712 )  
						
						... 
						
						
						
						Fixes https://github.com/microsoft/playwright/issues/18711  
						
						
					 
					
						2022-11-10 15:06:53 -08:00 
						 
				 
			
				
					
						
							
							
								Dmitry Gozman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							cafa558845 
							
						 
					 
					
						
						
							
							fix(codegen): update priorites in selector generator ( #18688 )  
						
						... 
						
						
						
						- prefer `role=checkbox` over `input[type=checkbox]`
- prefer `#id` over `input[type=checkbox]` and `role=checkbox`
- prefer `text=foo` over `internal:has-text=foo`
- ignore `none` and `presentation` roles
- remove non-strict support 
						
						
					 
					
						2022-11-09 17:22:13 -08:00 
						 
				 
			
				
					
						
							
							
								Pavel Feldman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							3f850d27e9 
							
						 
					 
					
						
						
							
							fix(highlight): fix the testing harness to be real ( #18294 )  
						
						
						
						
					 
					
						2022-10-24 15:01:48 -07:00 
						 
				 
			
				
					
						
							
							
								Pavel Feldman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							84daeafb3a 
							
						 
					 
					
						
						
							
							chore: use internal locator for role ( #18187 )  
						
						
						
						
					 
					
						2022-10-19 19:38:47 -07:00 
						 
				 
			
				
					
						
							
							
								Yury Semikhatsky 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							69092b153a 
							
						 
					 
					
						
						
							
							chore(codegen): do not generate  waitForURL ( #18167 )  
						
						... 
						
						
						
						Fixes https://github.com/microsoft/playwright/issues/17179  
						
						
					 
					
						2022-10-19 11:26:19 -07:00 
						 
				 
			
				
					
						
							
							
								Pavel Feldman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							304a4ee8ec 
							
						 
					 
					
						
						
							
							chore: migrate to the internal:text selector ( #18135 )  
						
						
						
						
					 
					
						2022-10-18 13:09:54 -07:00 
						 
				 
			
				
					
						
							
							
								Max Schmitt 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							a60073d664 
							
						 
					 
					
						
						
							
							fix(generator): .NET getByRole w/ name ( #18060 )  
						
						
						
						
					 
					
						2022-10-13 08:23:43 -07:00 
						 
				 
			
				
					
						
							
							
								Pavel Feldman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							35a5e805b3 
							
						 
					 
					
						
						
							
							fix(codegen): use constants when generating C# and Java roles ( #17961 )  
						
						... 
						
						
						
						Fixes #[17960](https://github.com/microsoft/playwright/issues/17960 ) 
						
						
					 
					
						2022-10-10 12:25:56 -07:00 
						 
				 
			
				
					
						
							
							
								Pavel Feldman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							1311767f87 
							
						 
					 
					
						
						
							
							chore: generate api calls ( #17794 )  
						
						
						
						
					 
					
						2022-10-03 17:14:02 -07:00 
						 
				 
			
				
					
						
							
							
								Pavel Feldman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							42a4d8a829 
							
						 
					 
					
						
						
							
							chore(codegen): prioritize role selectors ( #17750 )  
						
						
						
						
					 
					
						2022-10-03 08:44:24 -07:00 
						 
				 
			
				
					
						
							
							
								Pavel Feldman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							5754fb9c6d 
							
						 
					 
					
						
						
							
							chore: do not emit comments from codegen ( #17747 )  
						
						
						
						
					 
					
						2022-09-30 12:36:54 -07:00 
						 
				 
			
				
					
						
							
							
								Max Schmitt 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							e911eead9b 
							
						 
					 
					
						
						
							
							test: unflake 'should fill japanese text' ( #16431 )  
						
						
						
						
					 
					
						2022-08-11 08:48:55 +02:00 
						 
				 
			
				
					
						
							
							
								Max Schmitt 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							699a52ec74 
							
						 
					 
					
						
						
							
							fix(codegen): make sure input recording with japanese IME Work ( #16400 )  
						
						... 
						
						
						
						Co-authored-by: kawasaki.taiga <kigtaiga@gmail.com>
Co-authored-by: Max Schmitt <max@schmitt.mx> 
						
						
					 
					
						2022-08-10 09:46:30 +02:00 
						 
				 
			
				
					
						
							
							
								Yury Semikhatsky 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							11391910e7 
							
						 
					 
					
						
						
							
							Revert "fix(codegen): make sure input recording with japanese IME Wor… ( #16393 )  
						
						... 
						
						
						
						Revert "fix(codegen): make sure input recording with japanese IME Work (#16210 )"
This reverts commit 925de8da2b599f061889d808ba73ff535b39a9f4. 
						
						
					 
					
						2022-08-09 16:47:32 -07:00 
						 
				 
			
				
					
						
							
							
								YA2KM 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							925de8da2b 
							
						 
					 
					
						
						
							
							fix(codegen): make sure input recording with japanese IME Work ( #16210 )  
						
						... 
						
						
						
						Co-authored-by: kawasaki.taiga <kigtaiga@gmail.com>
Co-authored-by: Max Schmitt <max@schmitt.mx> 
						
						
					 
					
						2022-08-10 01:02:42 +02:00 
						 
				 
			
				
					
						
							
							
								Pavel Feldman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							d5ea1b38f0 
							
						 
					 
					
						
						
							
							fix(recorder): remove waitForNavigation from codegen ( #14166 )  
						
						
						
						
					 
					
						2022-05-18 10:02:09 -07:00 
						 
				 
			
				
					
						
							
							
								Pavel Feldman 
							
						 
					 
					
						
						
							
							
						
						
						
							
						
						
							02cac8a066 
							
						 
					 
					
						
						
							
							chore: group tests under tests/ (1) ( #13081 )  
						
						
						
						
					 
					
						2022-03-25 16:05:50 -07:00