22 Commits

Author SHA1 Message Date
Max Schmitt
e535b3aa5f
docs(best-practises): add note about saving browser downloads (#33568) 2024-11-13 12:11:12 +01:00
Denis LE
7a1739792f
docs(best-practices): improve wording (#33342) 2024-10-29 16:27:14 +01:00
Bruno
317ddd4117
docs(best practices): tabs with yarn and pnpm commands added (#32980) 2024-10-07 10:48:30 +02:00
Max Schmitt
6512bccffd
docs(best-practises): add note about tsc (#32245) 2024-08-21 11:37:53 +02:00
Simon Knott
244761a3a2
chore(docs): Rework CI docs (#31988)
This PR moves around some of our CI docs. It moves the GitHub actions
docs from `ci-intro.md` to `ci.md`, reduces `ci-intro.md` to be an
introduction, adds a mention of Sharding to the best practices, and adds
a section on `--only-changed` called "Fail-Fast". Each of those changes
is a separate commit, to make this a little easier to review. If we find
any of those to commits to be contentious, i'll pull them out into
individual PRs.

While rolling this to playwright.dev, we'll also make the following
changes to its sidebar:
- move the `ci.md` document from the "Integrations" section to the
"Playwright Test" section
- make "Best Practices" the last item of the "Getting Started" section

---------

Signed-off-by: Simon Knott <info@simonknott.de>
Co-authored-by: Yury Semikhatsky <yurys@chromium.org>
2024-08-20 09:03:02 +02:00
Max Schmitt
ac0a3fb275
docs(best-practises): make trace icon location more clear (#31909) 2024-07-30 11:19:07 +02:00
Josh Soref
7abbbd0c84
docs: spelling (#31779)
Fixes misspellings identified by the [check-spelling
action](https://github.com/marketplace/actions/check-spelling).

The misspellings have been reported at
https://github.com/jsoref/playwright/actions/runs/10015023629#summary-27685777352

The action will report that the changes in this PR would make it happy:
https://github.com/jsoref/playwright/actions/runs/10015023971#summary-27685778305

---

I understand that the commit messages will need to be reworded to match
house style. For the time being, these are merely noting the changes
they contain so that when I rebase or need to drop things, I can. --
I've already rebased once as someone fixed one of the items that my
draft work was going to fix.

---

## Testing
* The tests _mostly_ passed when I managed to trigger them, but there
were a handful of things that I didn't quite understand
* There are a large number of warnings relating to a bad interaction
between any workflow that uses this local action
b535139b32/.github/actions/run-test/action.yml (L74-L80)
and the action it calls -- I've opened Azure/login#474 asking them to
refactor their action so that it doesn't cause so much noise while
running this repository's tests
* I'm vaguely curious as to why this repository has a `branch`
constraint for its `pull_request` events in its workflows -- that
constraint gave me a number of additional headaches while trying to
prepare this branch for this PR.

---------

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
2024-07-22 06:45:22 -07:00
damar Zaky
96e0a96ac1
docs: fix grammar and typos in various files (#31678)
- docs/src/best-practices-js.md
- docs/src/codegen.md
- docs/src/debug.md
- docs/src/events.md
- docs/src/library-js.md
- docs/src/locators.md
- docs/src/other-locators.md
- docs/src/test-components-js.md
- docs/src/trace-viewer.md

---------

Signed-off-by: damar Zaky <damzaky@gmail.com>
2024-07-16 06:15:25 -07:00
Debbie O'Brien
3773f004db
docs: add intros for all pages (#27480) 2023-10-06 15:08:51 +02:00
jaktestowac.pl
6181960898
docs: best-practices update (#27267)
Best practices doc update:

- adding UI Mode to `Use Playwright's Tooling` section
- correcting heading for `Use parallelism and sharding` (previously this
section was falsy included in `Lint your tests`)

Fixes #27302
2023-09-26 12:26:15 -07:00
Steven Boutcher
4bf5b091d5
Fix run-on sentence in Best Practices docs (#26622) 2023-08-25 12:50:35 -07:00
Dmitry Gozman
c8b45aa844
chore: validate markdown links in doclint (#24444)
Fixes #24421.
2023-07-26 16:15:07 -07:00
Max Schmitt
9980f054bc
docs: align Node.js code snippets with ESLint (#23916) 2023-06-27 11:53:53 +02:00
Max Schmitt
aab322f2a1
docs(best-practises): recommend no-floating-promises (#23487)
https://github.com/microsoft/playwright/issues/23339

Signed-off-by: Max Schmitt <max@schmitt.mx>
Co-authored-by: Pavel Feldman <pavel.feldman@gmail.com>
2023-06-06 20:45:46 +02:00
Francois La Cock
49c8c6fa33
Update best-practices-js.md (#23466) 2023-06-02 13:05:17 -07:00
Debbie O'Brien
d2ea6588d7
docs(best-practises): improve soft assertions (#22909)
Co-authored-by: Max Schmitt <max@schmitt.mx>
2023-05-15 20:08:26 +02:00
Debbie O'Brien
7a8eb15820
docs: add titles to config snippets (#22910)
Docs PR: https://github.com/microsoft/playwright.dev/pull/1039

---------

Co-authored-by: Max Schmitt <max@schmitt.mx>
2023-05-10 18:38:12 +02:00
Max Schmitt
771abe15fb
docs(node): consolidate JS/TS snippets for guides (#21710)
https://github.com/microsoft/playwright/issues/21385
2023-03-16 21:16:18 +01:00
Jonatas Emidio
910b963ca6
docs: Avoid third-party with Network API (#21629)
docs: Avoid third-party with Network API

On the [Avoid testing third-party
dependencies](https://playwright.dev/docs/best-practices#avoid-testing-third-party-dependencies).
Instead of only inform about third-party, this sesison is a good place
to share about Network API. Guiding them in not only inform about
avoiding third-party, but also explaining how to deal with this use
case.

Signed-off-by: Jonatas Emidio <jonatasemidio@gmail.com>
2023-03-14 11:40:03 -07:00
IlinAlekseyS
5899348936
fix(best-practices): delete dublicate sentence (#20885) 2023-02-15 20:03:56 +01:00
Debbie O'Brien
e780a5c1ac
docs: improve best practices (#20106) 2023-01-16 10:52:36 +01:00
Debbie O'Brien
fa49803ca0
docs: Best practices (#19634) 2023-01-12 12:45:57 +01:00