4 Commits

Author	SHA1	Message	Date
Max Schmitt	ecf6f27159	fix: dark-mode in UI Mode (#33662)	2024-11-19 10:29:05 +01:00
Max Schmitt	878a6a499b	chore: prefer executablePath for page.pause() (#31985) ... Motivation: For scenarios where [`findChromiumChannel`](f17de8222f/packages/playwright-core/src/server/registry/index.ts (L1016)) throws (no branded browser and no normal browser is installed) we were [silently catching](f17de8222f/packages/playwright-core/src/server/recorder.ts (L79)) when calling `page.pause()`. This patch does not invoke `findChromiumChannel` when the inspectedContext is Chromium based and has an `executablePath` specified. Note this was already fixed by #6214, but regressed since then. Fixes https://github.com/microsoft/playwright/issues/31967	2024-08-02 11:18:51 +02:00
Simon Knott	76cca7fc2c	fix(ui): only populate settings once (#31958) ... We populate `localStorage` using an init script. Currently, this script isn't just run for the UI though, but also for all iframes. So we're resetting `localStorage` every time the UI loads an iframe. This hasn't been a problem in the past, because the only consumer of `localStorage`, `Settings`, only read from `localStorage` once and kept most state in `useState` afterwards. With https://github.com/microsoft/playwright/pull/31911, this is no longer true, so the bug starts biting us! The fix is to ensure the init script isn't run on iframes.	2024-08-01 17:28:48 +02:00
Max Schmitt	d79dad09e8	fix(ui-mode/tv): do not open new tab on macOS (#26877) ... Fixes https://github.com/microsoft/playwright/issues/9434	2023-09-06 22:57:29 +02:00