/** * Copyright (c) Microsoft Corporation. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. * You may obtain a copy of the License at * * http://www.apache.org/licenses/LICENSE-2.0 * * Unless required by applicable law or agreed to in writing, software * distributed under the License is distributed on an "AS IS" BASIS, * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. * See the License for the specific language governing permissions and * limitations under the License. */ import { test, expect } from './playwright-test-fixtures'; const description = 'This async call was not awaited by the end of the test. This can cause flakiness. It is recommended to run ESLint with "@typescript-eslint/no-floating-promises" to verify.'; test.describe.configure({ mode: 'parallel' }); test.describe('await', () => { test('should not care about non-API promises', async ({ runInlineTest }) => { const { exitCode, results } = await runInlineTest({ 'a.test.ts': ` import { test } from '@playwright/test'; test('test', async () => { new Promise(() => {}); await expect(page.locator('div')).toHaveText('A', { timeout: 100 }); }); ` }); expect(exitCode).toBe(1); expect(results[0].annotations).toEqual([]); }); test('should warn on failure', async ({ runInlineTest }) => { const { exitCode, results } = await runInlineTest({ 'a.test.ts': ` import { test, expect } from '@playwright/test'; test('custom test name', async ({ page }) => { expect(page.locator('div')).toHaveText('A', { timeout: 100 }); // Timeout to make sure the expect actually gets processed await new Promise(f => setTimeout(f, 1000)); }); ` }); expect(exitCode).toBe(1); expect(results[0].annotations).toEqual([{ type: 'warning', description, location: expect.objectContaining({ file: expect.stringMatching(/a\.test\.ts$/), line: 4, column: 39 }) }]); }); test('should not warn on success', async ({ runInlineTest }) => { const { exitCode, results } = await runInlineTest({ 'a.test.ts': ` import { test, expect } from '@playwright/test'; test('custom test name', async ({ page }) => { await page.setContent('
A
'); expect(page.locator('div')).toHaveText('A', { timeout: 100 }); await new Promise(f => setTimeout(f, 1000)); }); ` }); expect(exitCode).toBe(0); expect(results[0].annotations).toEqual([]); }); test('should warn about missing await on expects', async ({ runInlineTest }) => { const { exitCode, results } = await runInlineTest({ 'a.test.ts': ` import { test, expect } from '@playwright/test'; test('custom test name', async ({ page }) => { expect(page.locator('div')).toHaveText('A', { timeout: 100 }); await new Promise(f => setTimeout(f, 1000)); }); ` }); expect(exitCode).toBe(1); expect(results[0].annotations).toEqual([{ type: 'warning', description, location: expect.objectContaining({ file: expect.stringMatching(/a\.test\.ts$/), line: 4, column: 39 }) }]); }); test('should not warn when not missing await on expects', async ({ runInlineTest }) => { const { exitCode, results } = await runInlineTest({ 'a.test.ts': ` import { test, expect } from '@playwright/test'; test('test', async ({ page }) => { await expect(page.locator('div')).toHaveText('A', { timeout: 100 }); }); ` }); expect(exitCode).toBe(1); expect(results[0].annotations).toEqual([]); }); test('should not warn when using then() on expects', async ({ runInlineTest }) => { const { exitCode, results } = await runInlineTest({ 'a.test.ts': ` import { test, expect } from '@playwright/test'; test('test', async ({ page }) => { expect(page.locator('div')).toHaveText('A').then(() => {}); await new Promise(f => setTimeout(f, 1000)); }); ` }); expect(exitCode).toBe(1); expect(results[0].annotations).toEqual([]); }); test('should warn about missing await on resolve', async ({ runInlineTest }) => { const { exitCode, results } = await runInlineTest({ 'a.test.ts': ` import { test, expect } from '@playwright/test'; test('test', async ({ page }) => { expect(Promise.reject(new Error('foo'))).resolves.toBe('foo'); await new Promise(f => setTimeout(f, 1000)); }); ` }); expect(exitCode).toBe(1); expect(results[0].annotations).toEqual([{ type: 'warning', description, location: expect.objectContaining({ file: expect.stringMatching(/a\.test\.ts$/), line: 4, column: 61 }) }]); }); test('should warn about missing await on reject.not', async ({ runInlineTest }) => { const { exitCode, results } = await runInlineTest({ 'a.test.ts': ` import { test, expect } from '@playwright/test'; test('test', async ({ page }) => { expect(Promise.reject(new Error('foo'))).rejects.not.toThrow('foo'); await new Promise(f => setTimeout(f, 1000)); }); ` }); expect(exitCode).toBe(1); expect(results[0].annotations).toEqual([{ type: 'warning', description, location: expect.objectContaining({ file: expect.stringMatching(/a\.test\.ts$/), line: 4, column: 64 }) }]); }); test('should warn about missing await on test.step', async ({ runInlineTest }) => { const { exitCode, results } = await runInlineTest({ 'a.test.ts': ` import { test, expect } from '@playwright/test'; test('test', async ({ page }) => { test.step('step', () => {}); await expect(page.locator('div')).toHaveText('A', { timeout: 100 }); }); ` }); expect(exitCode).toBe(1); expect(results[0].annotations).toEqual([{ type: 'warning', description, location: expect.objectContaining({ file: expect.stringMatching(/a\.test\.ts$/), line: 4, column: 16 }) }]); }); test('should not warn when not missing await on test.step', async ({ runInlineTest }) => { const { exitCode, results } = await runInlineTest({ 'a.test.ts': ` import { test, expect } from '@playwright/test'; test('test', async ({ page }) => { await test.step('step', () => {}); await expect(page.locator('div')).toHaveText('A', { timeout: 100 }); }); ` }); expect(exitCode).toBe(1); expect(results[0].annotations).toEqual([]); }); test('should warn about missing await on test.step.skip', async ({ runInlineTest }) => { const { exitCode, results } = await runInlineTest({ 'a.test.ts': ` import { test, expect } from '@playwright/test'; test('test', async ({ page }) => { test.step.skip('step', () => {}); await expect(page.locator('div')).toHaveText('A'); }); ` }); expect(exitCode).toBe(1); expect(results[0].annotations).toEqual([{ type: 'warning', description, location: expect.objectContaining({ file: expect.stringMatching(/a\.test\.ts$/), line: 4, column: 21 }) }]); }); test('traced promise should be instanceof Promise', async ({ runInlineTest }) => { const { exitCode } = await runInlineTest({ 'a.test.ts': ` import { test, expect } from '@playwright/test'; test('test', async ({ page }) => { await page.setContent('
A
'); const expectPromise = expect(page.locator('div')).toHaveText('A'); expect(expectPromise instanceof Promise).toBeTruthy(); await new Promise(f => setTimeout(f, 1000)); }); ` }); expect(exitCode).toBe(0); }); test('should warn about missing await in before hooks', async ({ runInlineTest }) => { const group = ['beforeAll', 'beforeEach']; for (const hook of group) { await test.step(hook, async () => { const { exitCode, results } = await runInlineTest({ 'a.test.ts': ` import { test, expect } from '@playwright/test'; let page; test.${hook}(async ({ browser }) => { page = await browser.newPage(); await page.setContent('
A
'); expect(page.locator('div')).toHaveText('A'); await new Promise(f => setTimeout(f, 1000)); }); test('test ${hook}', async () => { await expect(page.locator('button')).toBeVisible({ timeout: 100 }); }); ` }); expect(exitCode).toBe(1); expect(results[0].annotations).toEqual([{ type: 'warning', description, location: expect.objectContaining({ file: expect.stringMatching(/a\.test\.ts$/), line: 7, column: 43 }) }]); }); } }); test.describe('should warn about missing await in after hooks', () => { const group = ['afterAll', 'afterEach']; for (const hook of group) { test(hook, async ({ runInlineTest }) => { const { exitCode, results } = await runInlineTest({ 'a.test.ts': ` import { test, expect } from '@playwright/test'; let page; test('test ${hook}', async ({ browser }) => { await expect(Promise.resolve()).resolves.toBe('A'); }); test.${hook}(async () => { expect(Promise.resolve()).resolves.toBe(undefined); await new Promise(f => setTimeout(f, 1000)); }); ` }); expect(exitCode).toBe(1); expect(results[0].annotations).toEqual([{ type: 'warning', description, location: expect.objectContaining({ file: expect.stringMatching(/a\.test\.ts$/), line: 8, column: 50 }) }]); }); } }); test('should warn about missing await across hooks and test', async ({ runInlineTest }) => { const { exitCode, results } = await runInlineTest({ 'a.test.ts': ` import { test, expect } from '@playwright/test'; test.beforeAll(async () => { expect(Promise.resolve()).resolves.toBe(undefined); await new Promise(f => setTimeout(f, 1000)); }); test('test', async () => { expect(Promise.resolve()).resolves.toBe('A'); await new Promise(f => setTimeout(f, 1000)); }); test.afterEach(async () => { expect(Promise.resolve()).resolves.toBe(undefined); await new Promise(f => setTimeout(f, 1000)); }); ` }); expect(exitCode).toBe(1); expect(results[0].annotations).toEqual([ { type: 'warning', description, location: expect.objectContaining({ file: expect.stringMatching(/a\.test\.ts$/), line: 4, column: 46 }) }, { type: 'warning', description, location: expect.objectContaining({ file: expect.stringMatching(/a\.test\.ts$/), line: 8, column: 46 }) }, { type: 'warning', description, location: expect.objectContaining({ file: expect.stringMatching(/a\.test\.ts$/), line: 12, column: 46 }) }, ]); }); test('should dedupe warnings that occur at the same location', async ({ runInlineTest }) => { const { exitCode, results } = await runInlineTest({ 'a.test.ts': ` import { test, expect } from '@playwright/test'; test('test', async ({ page }) => { for (let i = 0; i < 3; i++) { expect(page.locator('div')).toHaveText('A', { timeout: 100 }); } expect(page.locator('div')).toHaveText('A', { timeout: 100 }); await new Promise(f => setTimeout(f, 1000)); }); ` }); expect(exitCode).toBe(1); expect(results[0].annotations).toEqual([ { type: 'warning', description, location: expect.objectContaining({ file: expect.stringMatching(/a\.test\.ts$/), line: 5, column: 41 }) }, { type: 'warning', description, location: expect.objectContaining({ file: expect.stringMatching(/a\.test\.ts$/), line: 7, column: 39 }) }, ]); }); });