mirror of
				https://github.com/microsoft/playwright.git
				synced 2025-06-26 21:40:17 +00:00 
			
		
		
		
	 2f31e6373a
			
		
	
	
		2f31e6373a
		
			
		
	
	
	
	
		
			
			Currently, Mac WebKit builds are failing in CI. It seems this is a regression in upstream WebKit as I'm able to reproduce it in my local environment. The error is the following: ``` usr/bin/codesign --force --sign - --timestamp\=none --preserve-metadata\=identifier,entitlements,flags --generate-entitlement-der /Users/playwright/webkit/WebKitBuild/Release/InjectedBundleTestWebKitAPI.bundle/Contents/Resources/WebKit.framework /Users/playwright/webkit/WebKitBuild/Release/InjectedBundleTestWebKitAPI.bundle/Contents/Resources/WebKit.framework: replacing existing signature /Users/playwright/webkit/WebKitBuild/Release/InjectedBundleTestWebKitAPI.bundle/Contents/Resources/WebKit.framework: unsealed contents present in the root directory of an embedded framework Command CodeSign failed with a nonzero exit code ``` Bisecting the regression it seems the build started failing on [r295496](https://trac.webkit.org/changeset/295496/webkit) This changeset also introduced a new flag, _--no-use-workspace__, which allows to build not using WebKit.xcworkspace (I understand this is how builds were done before this changeset). Building with _--no-use-workspace_ fixes builds for Mac.
		
			
				
	
	
		
			88 lines
		
	
	
		
			3.1 KiB
		
	
	
	
		
			Bash
		
	
	
		
			Executable File
		
	
	
	
	
			
		
		
	
	
			88 lines
		
	
	
		
			3.1 KiB
		
	
	
	
		
			Bash
		
	
	
		
			Executable File
		
	
	
	
	
| #!/bin/bash
 | |
| set -e
 | |
| set +x
 | |
| 
 | |
| trap "cd $(pwd -P)" EXIT
 | |
| cd "$(dirname "$0")"
 | |
| SCRIPT_FOLDER="$(pwd -P)"
 | |
| source "${SCRIPT_FOLDER}/../utils.sh"
 | |
| 
 | |
| build_gtk() {
 | |
|   if ! [[ -d ./WebKitBuild/GTK/DependenciesGTK ]]; then
 | |
|     yes | WEBKIT_JHBUILD=1 WEBKIT_JHBUILD_MODULESET=minimal WEBKIT_OUTPUTDIR=$(pwd)/WebKitBuild/GTK DEBIAN_FRONTEND=noninteractive ./Tools/Scripts/update-webkitgtk-libs
 | |
|   fi
 | |
|   local CMAKE_ARGS=(
 | |
|     --cmakeargs=-DENABLE_INTROSPECTION=OFF
 | |
|     --cmakeargs=-DUSE_GSTREAMER_WEBRTC=FALSE
 | |
|   )
 | |
|   if [[ -n "${EXPORT_COMPILE_COMMANDS}" ]]; then
 | |
|     CMAKE_ARGS+=("--cmakeargs=-DCMAKE_EXPORT_COMPILE_COMMANDS=1")
 | |
|   fi
 | |
|   WEBKIT_JHBUILD=1 WEBKIT_JHBUILD_MODULESET=minimal WEBKIT_OUTPUTDIR=$(pwd)/WebKitBuild/GTK ./Tools/Scripts/build-webkit --gtk --release "${CMAKE_ARGS}" --touch-events --orientation-events --no-bubblewrap-sandbox "${CMAKE_ARGS[@]}" MiniBrowser
 | |
| }
 | |
| 
 | |
| build_wpe() {
 | |
|   if ! [[ -d ./WebKitBuild/WPE/DependenciesWPE ]]; then
 | |
|     yes | WEBKIT_JHBUILD=1 WEBKIT_JHBUILD_MODULESET=minimal WEBKIT_OUTPUTDIR=$(pwd)/WebKitBuild/WPE DEBIAN_FRONTEND=noninteractive ./Tools/Scripts/update-webkitwpe-libs
 | |
|   fi
 | |
|   local CMAKE_ARGS=(
 | |
|     --cmakeargs=-DENABLE_COG=OFF
 | |
|     --cmakeargs=-DENABLE_INTROSPECTION=OFF
 | |
|     --cmakeargs=-DENABLE_WEBXR=OFF
 | |
|     --cmakeargs=-DUSE_GSTREAMER_WEBRTC=FALSE
 | |
|   )
 | |
|   if [[ -n "${EXPORT_COMPILE_COMMANDS}" ]]; then
 | |
|     CMAKE_ARGS+=("--cmakeargs=-DCMAKE_EXPORT_COMPILE_COMMANDS=1")
 | |
|   fi
 | |
|   WEBKIT_JHBUILD=1 WEBKIT_JHBUILD_MODULESET=minimal WEBKIT_OUTPUTDIR=$(pwd)/WebKitBuild/WPE ./Tools/Scripts/build-webkit --wpe --release "${CMAKE_ARGS}" --touch-events --orientation-events --no-bubblewrap-sandbox "${CMAKE_ARGS[@]}" MiniBrowser
 | |
| }
 | |
| 
 | |
| ensure_linux_deps() {
 | |
|   yes | DEBIAN_FRONTEND=noninteractive ./Tools/gtk/install-dependencies
 | |
|   yes | DEBIAN_FRONTEND=noninteractive ./Tools/wpe/install-dependencies
 | |
|   yes | DEBIAN_FRONTEND=noninteractive WEBKIT_JHBUILD=1 WEBKIT_JHBUILD_MODULESET=minimal WEBKIT_OUTPUTDIR=$(pwd)/WebKitBuild/WPE ./Tools/Scripts/update-webkitwpe-libs
 | |
|   yes | DEBIAN_FRONTEND=noninteractive WEBKIT_JHBUILD=1 WEBKIT_JHBUILD_MODULESET=minimal WEBKIT_OUTPUTDIR=$(pwd)/WebKitBuild/GTK ./Tools/Scripts/update-webkitgtk-libs
 | |
| }
 | |
| 
 | |
| if [[ ! -z "${WK_CHECKOUT_PATH}" ]]; then
 | |
|   cd "${WK_CHECKOUT_PATH}"
 | |
|   echo "WARNING: checkout path from WK_CHECKOUT_PATH env: ${WK_CHECKOUT_PATH}"
 | |
| else
 | |
|   cd "$HOME/webkit"
 | |
| fi
 | |
| 
 | |
| if is_mac; then
 | |
|   selectXcodeVersionOrDie $(node "$SCRIPT_FOLDER/../get_xcode_version.js" webkit)
 | |
|   ./Tools/Scripts/build-webkit --release --touch-events --orientation-events --no-use-workspace
 | |
| elif is_linux; then
 | |
|   if [[ $# == 0 || (-z "$1") ]]; then
 | |
|     echo
 | |
|     echo BUILDING: GTK and WPE
 | |
|     echo
 | |
|     build_wpe
 | |
|     build_gtk
 | |
|   elif [[ "$1" == "--full" ]]; then
 | |
|     echo
 | |
|     echo BUILDING: GTK and WPE
 | |
|     echo
 | |
|     ensure_linux_deps
 | |
|     build_wpe
 | |
|     build_gtk
 | |
|   elif [[ "$1" == "--gtk" ]]; then
 | |
|     echo
 | |
|     echo BUILDING: GTK
 | |
|     echo
 | |
|     build_gtk
 | |
|   elif [[ "$1" == "--wpe" ]]; then
 | |
|     echo
 | |
|     echo BUILDING: WPE
 | |
|     echo
 | |
|     build_wpe
 | |
|   fi
 | |
| elif is_win; then
 | |
|   /c/Windows/System32/cmd.exe "/c $(cygpath -w "${SCRIPT_FOLDER}"/buildwin.bat)"
 | |
| else
 | |
|   echo "ERROR: cannot upload on this platform!" 1>&2
 | |
|   exit 1;
 | |
| fi
 |