mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00

History

Yury Semikhatsky 82981a8091

fix: interception id not found error in route.continue (#29180 )

We stopped catching all exceptions in
https://github.com/microsoft/playwright/pull/28539 in hope that we'll
get loadingFailed even before Fetch.continue/fulfill command's error.
Turns out this is racy and may fail if the test cancels the request
while we are continuing it. The following test could in theory reproduce
it if stars align and the timing is good:

```js
it('page.continue on canceled request', async ({ page }) => {
  let resolveRoute;
  const routePromise = new Promise<Route>(f => resolveRoute = f);
  await page.route('http://test.com/x', resolveRoute);

  const evalPromise = page.evaluate(async () => {
    const abortController = new AbortController();
    (window as any).abortController = abortController;
    return fetch('http://test.com/x', { signal: abortController.signal }).catch(e => 'cancelled');
  });
  const route = await routePromise;
  void page.evaluate(() => (window as any).abortController.abort());
  await new Promise(f => setTimeout(f, 10));
  await route.continue();
  const req = await evalPromise;
  expect(req).toBe('cancelled');
});
```

Fixes https://github.com/microsoft/playwright/issues/29123

2024-01-25 16:54:42 -08:00

bin

chore: better error messages when stable channel installations fail on Windows (#29077 )

2024-01-22 18:15:35 +01:00

bundles

chore: get rid of rimraf package (#27790 )

2023-10-26 19:41:00 +02:00

src

fix: interception id not found error in route.continue (#29180 )

2024-01-25 16:54:42 -08:00

types

feat(chromium): roll to r1100 (#29167 )