mirror of
https://github.com/microsoft/playwright.git
synced 2025-06-26 21:40:17 +00:00
abb50a79bd
Firefox will sometimes send multiple requests with the same http channel id. When a frame is loaded, the favicon is requested in the parent frame, but with the same channel id. This can cause the document request to report the wrong frame, causing the test 'should capture iframe navigation request' to fail. It fails consistently on my computer. This patch adds the content policy type into the http channelId to better distinguish requests. Maybe there is something better we can do? It looks like we use channelId has request ids, so there might be more bugs with these favicon requests in playwright?
62 lines
1.9 KiB
JavaScript
62 lines
1.9 KiB
JavaScript
/* This Source Code Form is subject to the terms of the Mozilla Public
|
|
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
|
* file, You can obtain one at http://mozilla.org/MPL/2.0/. */
|
|
|
|
"use strict";
|
|
const Ci = Components.interfaces;
|
|
const Cr = Components.results;
|
|
const Cu = Components.utils;
|
|
|
|
const {Helper} = ChromeUtils.import('chrome://juggler/content/Helper.js');
|
|
|
|
const helper = new Helper();
|
|
|
|
class NetworkMonitor {
|
|
constructor(rootDocShell, frameTree) {
|
|
this._frameTree = frameTree;
|
|
this._requestDetails = new Map();
|
|
|
|
this._eventListeners = [
|
|
helper.addObserver(this._onRequest.bind(this), 'http-on-opening-request'),
|
|
];
|
|
}
|
|
|
|
_onRequest(channel) {
|
|
if (!(channel instanceof Ci.nsIHttpChannel))
|
|
return;
|
|
const httpChannel = channel.QueryInterface(Ci.nsIHttpChannel);
|
|
const loadContext = helper.getLoadContext(httpChannel);
|
|
if (!loadContext)
|
|
return;
|
|
try {
|
|
const window = loadContext.associatedWindow;
|
|
const frame = this._frameTree.frameForDocShell(window.docShell);
|
|
if (!frame)
|
|
return;
|
|
const typeId = httpChannel.loadInfo ? httpChannel.loadInfo.internalContentPolicyType : Ci.nsIContentPolicy.TYPE_OTHER;
|
|
// Channel ids are not unique. We combine them with the typeId
|
|
// to better distinguish requests. For example, favicon requests
|
|
// have the same channel id as their associated document request.
|
|
const channelKey = httpChannel.channelId + ':' + typeId;
|
|
this._requestDetails.set(channelKey, {
|
|
frameId: frame.id(),
|
|
});
|
|
} catch (e) {
|
|
// Accessing loadContext.associatedWindow sometimes throws.
|
|
}
|
|
}
|
|
|
|
requestDetails(channelKey) {
|
|
return this._requestDetails.get(channelKey) || null;
|
|
}
|
|
|
|
dispose() {
|
|
this._requestDetails.clear();
|
|
helper.removeListeners(this._eventListeners);
|
|
}
|
|
}
|
|
|
|
var EXPORTED_SYMBOLS = ['NetworkMonitor'];
|
|
this.NetworkMonitor = NetworkMonitor;
|
|
|