playwright

mirror of https://github.com/microsoft/playwright.git synced 2025-06-26 21:40:17 +00:00

History

Andrey Lushnikov e28083974d

browser(firefox): simplify PageTarget lifecycle (#4014 )

As of today, we create `PageTarget` instances whenever we get a
sync IPC from the content process. This, however, breaks an invariant
that `browserContext.pages` always has all pages (and *browsing contexts* - not to be confused with *browser contexts*), associated with browser context. This invariant will be especially important when we move
user agent emulation to browser-side.

This patch makes `PageTarget` lifecycle symmetrical:
- `PageTarget` instance is created when tab is opened
- `PageTarget` is destroyed when tab is crashed or closed

This should also fix a bunch of race conditions with persistent mode, since sometimes we arrive to the window after its
initialization.

Drive-by: straighten viewport management and put a nice descriptive comment.

2020-09-30 02:10:34 -07:00

juggler

browser(firefox): simplify PageTarget lifecycle (#4014 )

2020-09-30 02:10:34 -07:00

patches

browser(firefox): remove the hack around setting viewport size (#4010 )

2020-09-30 00:36:46 -07:00

preferences

browser(firefox): force firefox devtools to open in a separate window (#3816 )

2020-09-09 09:36:32 -07:00

.gitignore

Initial commit