168 lines
5.5 KiB
JavaScript
Raw Normal View History

I18n/ permissions rework (#9535) * Add a domain layer for the permission, rework the engine handling of the permissions Signed-off-by: Convly <jean-sebastien.herbaux@epitech.eu> * Add permissions-fields-to-properties migration for the admin Signed-off-by: Convly <jean-sebastien.herbaux@epitech.eu> * Removes useless console.log Signed-off-by: Convly <jean-sebastien.herbaux@epitech.eu> * Remove debug logLevel from provider-login.test.e2e.js Signed-off-by: Convly <jean-sebastien.herbaux@epitech.eu> * Adds the new layout for the GET permissions, allow to subscribe to actionRegistered events, adds i18n handlers Signed-off-by: Convly <jean-sebastien.herbaux@epitech.eu> * Fix typo Signed-off-by: Convly <jean-sebastien.herbaux@epitech.eu> * Update permissions validators Signed-off-by: Convly <jean-sebastien.herbaux@epitech.eu> * Update unit tests Signed-off-by: Convly <jean-sebastien.herbaux@epitech.eu> * Update integrations test + fix some validation issues Signed-off-by: Convly <jean-sebastien.herbaux@epitech.eu> * Change plugins & settings section format for the permissions layout * only return locales property to localized subjects for the permission's layout * Do not send the locales property to the permission's layout when there is no locales created * Add the 'locales' property to publish & delete routes * Fix unwanted mutation of the sections builder states on multiple builds * Fix units tests with (new engine) * Fix admin-role e2e test - Add locales property to the update payload * fix e2e testsé * Update e2e snapshots * Fix unit test for i18n bootstrap * Add mocks for i18n/bootstrap test * Fix has-locale condition & updatePermission validator * Avoid mutation in migration, always authorize super admin for has-locales condition * Rework rbac domain objects, add a hook module and a provider factory * Remove old providers * Update the admin services & tests for the new rbac domain & providers * Fix tests, bootstrap functions & services following rbac domain rework * Update migration runner * PR comments Signed-off-by: Convly <jean-sebastien.herbaux@epitech.eu> * Remove useless console.log * Fix sanitizeCondition bug * Section builder rework * Add test for the section-builder section & add jsdoc for the permission domain * pr comments (without the migrations) * fix fields-to-properties migration * Add jsdoc for the sections-builder * Moves createBoundAbstractDomain from permission domain to the engine service * Remove debug logLevel for admin role test (e2e) * Fix core-store * Fix hooks & move business logic from i18n bootstrap to dedicated services * add route get-non-localized-fields * use write and read permission * refacto * add input validator * add route doc * handle ST Co-authored-by: Pierre Noël <petersg83@gmail.com> Co-authored-by: Alexandre BODIN <alexandrebodin@users.noreply.github.com>
2021-03-25 14:59:44 +01:00
'use strict';
const hooks = require('../hooks');
describe('Hooks Module', () => {
describe('Internals', () => {
describe('createHook', () => {
test(`It's possible to create a hook that has all the needed methods`, () => {
const hook = hooks.internals.createHook();
expect(hook).toHaveProperty('handlers', expect.any(Array));
expect(hook).toHaveProperty('register', expect.any(Function));
expect(hook).toHaveProperty('delete', expect.any(Function));
expect(hook).toHaveProperty('call', expect.any(Function));
});
test('Call is not implemented by default', async () => {
const hook = hooks.internals.createHook();
const doCall = () => hook.call('foo');
expect(doCall).toThrowError('Method not implemented');
});
});
});
describe('Hooks', () => {
describe('Async Series Hook', () => {
test('Can create an async series hook (from factory)', () => {
const hook = hooks.createAsyncSeriesHook();
expect(hook).toHaveProperty('register', expect.any(Function));
expect(hook).toHaveProperty('call', expect.any(Function));
});
test('Running a hook without any handler does nothing', async () => {
const ctx = { foo: 'bar' };
const hook = hooks.createAsyncSeriesHook();
await hook.call(ctx);
expect(ctx).toMatchObject({ foo: 'bar' });
});
test('Running a hook with an handler can mutate the context', async () => {
const ctx = { foo: 'bar' };
const handler = jest.fn(context => {
context.foo = 'foo';
});
const hook = hooks.createAsyncSeriesHook();
hook.register(handler);
await hook.call(ctx);
expect(handler).toHaveBeenCalled();
expect(ctx).toHaveProperty('foo', 'foo');
});
test('Running a hook with multiple handlers can mutate the hook in order', async () => {
const ctx = { foo: [] };
const handlers = [
jest.fn(context => context.foo.push('foo')),
jest.fn(context => context.foo.push('bar')),
];
const hook = hooks.createAsyncSeriesHook();
handlers.forEach(handler => hook.register(handler));
await hook.call(ctx);
handlers.forEach(handler => expect(handler).toHaveBeenCalled());
expect(ctx).toHaveProperty('foo', ['foo', 'bar']);
});
});
describe('Async Series Waterfall Hook', () => {
test('Can create an async series waterfall hook (from factory)', () => {
const hook = hooks.createAsyncSeriesWaterfallHook();
expect(hook).toHaveProperty('register', expect.any(Function));
expect(hook).toHaveProperty('call', expect.any(Function));
});
test('Running a hook without any handler returns the initial param (from hook.call)', async () => {
const param = 'foo';
const hook = hooks.createAsyncSeriesWaterfallHook();
const result = await hook.call(param);
expect(result).toEqual(param);
});
test('Running a hook with an handler can update the final value', async () => {
const param = 'foo';
const handler = jest.fn(param => [param, 'bar']);
const hook = hooks.createAsyncSeriesWaterfallHook();
hook.register(handler);
const result = await hook.call(param);
expect(handler).toHaveBeenCalled();
expect(result).toEqual(['foo', 'bar']);
});
test(`Running a hook with multiple handlers means every handler will receive the previous one's result`, async () => {
const param = 'foo';
const handlers = [jest.fn(param => `${param}.bar`), jest.fn(param => `${param}.foobar`)];
const hook = hooks.createAsyncSeriesWaterfallHook();
handlers.forEach(handler => hook.register(handler));
const result = await hook.call(param);
handlers.forEach(handler => expect(handler).toHaveBeenCalled());
expect(result).toEqual('foo.bar.foobar');
});
});
describe('Async Parallel Hook', () => {
test('Can create an async parallel hook (from factory)', () => {
const hook = hooks.createAsyncParallelHook();
expect(hook).toHaveProperty('register', expect.any(Function));
expect(hook).toHaveProperty('call', expect.any(Function));
});
test('Running a hook without any handler returns an empty array (from hook.call)', async () => {
const param = 'foo';
const hook = hooks.createAsyncParallelHook();
const result = await hook.call(param);
expect(result).toEqual([]);
});
test('Running a hook with an handler returns its value', async () => {
const param = 'test';
const handler = jest.fn(param => `${param}.bar`);
const hook = hooks.createAsyncParallelHook();
hook.register(handler);
const result = await hook.call(param);
expect(handler).toHaveBeenCalled();
expect(result).toEqual(['test.bar']);
});
test(`Running a hook with multiple handlers return every result as an array`, async () => {
const param = 'test';
const handlers = [jest.fn(param => `${param}.foo`), jest.fn(param => `${param}.bar`)];
const hook = hooks.createAsyncParallelHook();
handlers.forEach(handler => hook.register(handler));
const result = await hook.call(param);
handlers.forEach(handler => expect(handler).toHaveBeenCalled());
expect(result).toEqual(['test.foo', 'test.bar']);
});
});
});
});