yujunjun/strapi
1
0
Fork 0
mirror of https://github.com/strapi/strapi.git synced 2025-11-02 10:55:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix: Fix infinite rendering loop of role edit page

Browse Source
This commit is contained in:
Gustav Hansen 2023-06-23 15:06:39 +02:00
parent 553217bd1c
commit 04314f11f8
1 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
packages/core/admin/admin/src/pages/SettingsPage/pages/Roles/ProtectedEditPage/index.js
View File

@ -9,13 +9,20 @@ import EditPage from '../EditPage';
const ProtectedEditPage = () => {
const permissions = useSelector(selectAdminPermissions);
// TODO: this is necessary because otherwise we run into an
// infinite rendering loop
const permissionsMemoized = React.useMemo(() => {
return {
read: permissions.settings.roles.read,
update: permissions.settings.roles.update,
};
}, [permissions.settings.roles.read, permissions.settings.roles.update]);
const {
isLoading,
allowedActions: { canRead, canUpdate },
} = useRBAC({
read: permissions.settings.roles.read,
update: permissions.settings.roles.update,
});
} = useRBAC(permissionsMemoized);
if (isLoading) {
return <LoadingIndicatorPage />;