yujunjun/strapi
1
0
Fork 0
mirror of https://github.com/strapi/strapi.git synced 2025-11-19 03:29:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix template semver check

Browse Source
This commit is contained in:
Rémi de Juvigny 2021-10-26 11:46:14 +02:00
parent 3f4fb48a41
commit 0b073e9c95
1 changed files with 32 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

42
packages/generators/app/lib/utils/merge-template.js
View File

@ -48,7 +48,7 @@ module.exports = async function mergeTemplate(scope, rootPath) {
} }
// Make sure the template is compatible with this version of strapi // Make sure the template is compatible with this version of strapi
checkTemplateCompat(rootPath, scope.strapiVersion); checkTemplateCompat(templatePath, scope.strapiVersion);
// Make sure the downloaded template matches the required format // Make sure the downloaded template matches the required format
const { templateConfig } = await checkTemplateRootStructure(templatePath, scope); const { templateConfig } = await checkTemplateRootStructure(templatePath, scope);
@ -64,18 +64,40 @@ module.exports = async function mergeTemplate(scope, rootPath) {
} }
}; };
function checkTemplateCompat({ rootPath, strapiVersion, templatePackageInfo }) { /**
const packageJSON = require(path.resolve(rootPath, 'package.json')); * Make sure the template is compatible with a specific Strapi version
* @param {string} templatePath - Where the template is installed
* @param {string} strapiVersion - Strapi version of the app being created
*/
function checkTemplateCompat(templatePath, strapiVersion) {
const packageJSON = require(path.resolve(templatePath, 'package.json'));
const compatibleStrapiRange = packageJSON.strapi; const compatibleStrapiRange = packageJSON.strapi;
// Throw error if not compatible
const isCompatible = semver.satisfies(strapiVersion, compatibleStrapiRange); // Make sure the Strapi compatibility range is set
if (compatibleStrapiRange == null) {
throw new Error('This template does not specify a range of compatible Strapi versions');
}
// Check that the range is set using proper semver
const validCompatibleStrapiRange = semver.validRange(compatibleStrapiRange);
if (!validCompatibleStrapiRange) {
throw new Error(
'Please use semver to specify the range of Strapi versions compatible with this plugin'
);
}
// Check if the template is compatible with this Strapi version
const coercedStrapiVersion = semver.coerce(strapiVersion, { includePrerelease: true });
const isCompatible = semver.satisfies(coercedStrapiVersion, validCompatibleStrapiRange, {
includePrerelease: true,
});
if (!isCompatible) { if (!isCompatible) {
const { name, version } = templatePackageInfo;
throw new Error(` throw new Error(`
The template ${chalk.green( This template is not compatible with Strapi version ${strapiVersion}.
`${name}@${version}` It will only work with Strapi versions in the range ${chalk.green(
)} is not compatible with Strapi version ${strapiVersion}. JSON.stringify(compatibleStrapiRange)
It will only work with Strapi versions in the range ${chalk.green(compatibleStrapiRange)}. )}.
Try using a different Strapi version, or a different version of this template instead
`); `);
} }
} }