yujunjun/strapi
1
0
Fork 0
mirror of https://github.com/strapi/strapi.git synced 2025-09-17 04:17:21 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #15895 from strapi/data-transfer/limit-token-name-length

Browse Source 
No length limit on the name for the API token or transfer token
This commit is contained in:
Simone 2023-03-13 09:16:36 +01:00 committed by GitHub
commit 19711041d8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
10 changed files with 51 additions and 23 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
packages/core/admin/admin/src/pages/SettingsPage/components/Tokens/FormHead/index.js
View File

@ -69,6 +69,7 @@ const FormHead = ({
})}
</Link>
}
ellipsis
/>
);
};

4
packages/core/admin/admin/src/pages/SettingsPage/components/Tokens/Table/index.js
View File

@ -63,8 +63,8 @@ const Table = ({
condition: canUpdate,
})}
>
<Td>
<Typography textColor="neutral800" fontWeight="bold">
<Td maxWidth={pxToRem(250)}>
<Typography textColor="neutral800" fontWeight="bold" ellipsis>
{token.name}
</Typography>
</Td>

8
packages/core/admin/admin/src/pages/SettingsPage/pages/ApiTokens/EditView/tests/__snapshots__/index.test.js.snap
View File

@ -275,6 +275,10 @@ exports[`ADMIN | Pages | API TOKENS | EditView renders and matches the snapshot
font-weight: 600;
font-size: 2rem;
line-height: 1.25;
display: block;
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
color: #32324d;
}
@ -1824,6 +1828,10 @@ exports[`ADMIN | Pages | API TOKENS | EditView renders and matches the snapshot
font-weight: 600;
font-size: 2rem;
line-height: 1.25;
display: block;
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
color: #32324d;
}

2
packages/core/admin/admin/src/pages/SettingsPage/pages/ApiTokens/EditView/utils/schema.js
View File

@ -2,7 +2,7 @@ import * as yup from 'yup';
import { translatedErrors } from '@strapi/helper-plugin';
const schema = yup.object().shape({
name: yup.string(translatedErrors.string).required(translatedErrors.required),
name: yup.string(translatedErrors.string).max(100).required(translatedErrors.required),
type: yup
.string(translatedErrors.string)
.oneOf(['read-only', 'full-access', 'custom'])

14
packages/core/admin/admin/src/pages/SettingsPage/pages/ApiTokens/ListView/tests/index.test.js
View File

@ -158,7 +158,7 @@ describe('ADMIN | Pages | API TOKENS | ListPage', () => {
cursor: pointer;
}
.c36 {
.c35 {
max-width: 15.625rem;
}
@ -255,9 +255,13 @@ describe('ADMIN | Pages | API TOKENS | ListPage', () => {
color: #666687;
}
.c35 {
.c36 {
font-size: 0.875rem;
line-height: 1.43;
display: block;
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
font-weight: 600;
color: #32324d;
}
@ -919,19 +923,19 @@ describe('ADMIN | Pages | API TOKENS | ListPage', () => {
>
<td
aria-colindex="1"
class="c25"
class="c35 c25"
role="gridcell"
tabindex="-1"
>
<span
class="c5 c35"
class="c5 c36"
>
My super token
</span>
</td>
<td
aria-colindex="2"
class="c36 c25"
class="c35 c25"
role="gridcell"
tabindex="-1"
>

8
packages/core/admin/admin/src/pages/SettingsPage/pages/TransferTokens/EditView/tests/__snapshots__/index.test.js.snap
View File

@ -148,6 +148,10 @@ exports[`ADMIN | Pages | TRANSFER TOKENS | EditView renders and matches the snap
font-weight: 600;
font-size: 2rem;
line-height: 1.25;
display: block;
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
color: #32324d;
}
@ -1121,6 +1125,10 @@ exports[`ADMIN | Pages | TRANSFER TOKENS | EditView renders and matches the snap
font-weight: 600;
font-size: 2rem;
line-height: 1.25;
display: block;
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
color: #32324d;
}

2
packages/core/admin/admin/src/pages/SettingsPage/pages/TransferTokens/EditView/utils/schema.js
View File

@ -2,7 +2,7 @@ import * as yup from 'yup';
import { translatedErrors } from '@strapi/helper-plugin';
const schema = yup.object().shape({
name: yup.string(translatedErrors.string).required(translatedErrors.required),
name: yup.string(translatedErrors.string).max(100).required(translatedErrors.required),
description: yup.string().nullable(),
lifespan: yup.number().integer().min(0).nullable().defined(translatedErrors.required),
});

14
packages/core/admin/admin/src/pages/SettingsPage/pages/TransferTokens/ListView/tests/index.test.js
View File

@ -158,7 +158,7 @@ describe('ADMIN | Pages | TRANSFER TOKENS | ListPage', () => {
cursor: pointer;
}
.c36 {
.c35 {
max-width: 15.625rem;
}
@ -255,9 +255,13 @@ describe('ADMIN | Pages | TRANSFER TOKENS | ListPage', () => {
color: #666687;
}
.c35 {
.c36 {
font-size: 0.875rem;
line-height: 1.43;
display: block;
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
font-weight: 600;
color: #32324d;
}
@ -919,19 +923,19 @@ describe('ADMIN | Pages | TRANSFER TOKENS | ListPage', () => {
>
<td
aria-colindex="1"
class="c25"
class="c35 c25"
role="gridcell"
tabindex="-1"
>
<span
class="c5 c35"
class="c5 c36"
>
My super token
</span>
</td>
<td
aria-colindex="2"
class="c36 c25"
class="c35 c25"
role="gridcell"
tabindex="-1"
>

13
packages/core/helper-plugin/lib/src/components/DateTimePicker/DateTimePicker.stories.mdx
View File

@ -10,14 +10,14 @@ import DateTimePicker from './index';
argTypes={{
label: {
control: {
type: 'text'
}
type: 'text',
},
},
value: {
control: {
type: 'date'
}
}
type: 'date',
},
},
}}
/>
@ -37,7 +37,7 @@ Description...
<DateTimePicker
onClear={() => setValue(undefined)}
value={value}
onChange={e => setValue(e)}
onChange={(e) => setValue(e)}
label="Date time picker"
hint="This is a super description"
/>
@ -53,6 +53,7 @@ Description...
<Canvas>
<Story name="error">
<DateTimePicker
label="Date time picker"
hint="This is a super description"
error="Very very very very very very very long error"
/>

2
packages/core/helper-plugin/lib/src/components/FilterPopoverURLQuery/FilterPopoverURLQuery.stories.mdx
View File

@ -4,6 +4,7 @@ import { useEffect, useState, useRef } from 'react';
import { Meta, ArgsTable, Canvas, Story } from '@storybook/addon-docs';
import { Button, Box, Main, Flex } from '@strapi/design-system';
import useQueryParams from '../../hooks/useQueryParams';
import useTracking from '../../hooks/useTracking';
import FilterListURLQuery from '../FilterListURLQuery';
import FilterPopoverURLQuery from './index';
@ -51,6 +52,7 @@ import { FilterListURLQuery } from '@strapi/helper-plugin';
metadatas: { label: 'city' },
},
];
const { trackUsage } = useTracking();
return (
<Main>
<Flex direction="column" alignItems="stretch" gap={6}>