Fix components relations in CTB and missing transform in REST API

examples/getstarted/src/api/kitchensink/content-types/kitchensink/schema.json

@@ -5,7 +5,8 @@
     "displayName": "Kitchen Sink",
     "singularName": "kitchensink",
     "pluralName": "kitchensinks",
-    "description": ""
+    "description": "",
+    "name": "Kitchen Sink"
   },
   "options": {
     "draftAndPublish": true
@@ -100,7 +101,8 @@
     "dynamiczone": {
       "type": "dynamiczone",
       "components": [
-        "basic.simple"
+        "basic.simple",
+        "basic.kitchensink"
       ]
     },
     "one_way_tag": {
@@ -145,6 +147,11 @@
     "morph_to_many": {
       "type": "relation",
       "relation": "morphToMany"
+    },
+    "compo": {
+      "type": "component",
+      "repeatable": false,
+      "component": "basic.kitchensink"
     }
   }
 }

examples/getstarted/src/components/basic/kitchensink.json

@@ -0,0 +1,24 @@
+{
+  "collectionName": "components_basic_kitchensinks",
+  "info": {
+    "name": "kitchensink",
+    "icon": "adjust",
+    "description": ""
+  },
+  "options": {},
+  "attributes": {
+    "address": {
+      "type": "relation",
+      "relation": "oneToOne",
+      "target": "api::address.address"
+    },
+    "countries": {
+      "type": "relation",
+      "relation": "oneToMany",
+      "target": "api::country.country"
+    },
+    "name": {
+      "type": "string"
+    }
+  }
+}

packages/core/content-type-builder/server/controllers/validation/component.js

@@ -9,7 +9,7 @@ const { isValidCategoryName, isValidIcon } = require('./common');
 const createSchema = require('./model-schema');
 const { removeEmptyDefaults } = require('./data-transform');
 
-const VALID_RELATIONS = ['oneWay', 'manyWay'];
+const VALID_RELATIONS = ['oneToOne', 'oneToMany'];
 const VALID_TYPES = [...DEFAULT_TYPES, 'component'];
 
 const componentSchema = createSchema(VALID_TYPES, VALID_RELATIONS, {

packages/core/strapi/lib/core-api/controller/transform.js

@@ -49,6 +49,22 @@ const transformEntry = (entry, contentType) => {
       const data = transformEntry(property, strapi.contentType(attribute.target));
 
       attributeValues[key] = { data };
+    } else if (attribute && attribute.type === 'component') {
+      const { id, attributes } = transformEntry(property, strapi.components[attribute.component]);
+      attributeValues[key] = { id, ...attributes };
+    } else if (attribute && attribute.type === 'dynamiczone') {
+      if (Array.isArray(property)) {
+        attributeValues[key] = property.map(subProperty => {
+          const { id, attributes } = transformEntry(
+            subProperty,
+            strapi.components[subProperty.__component]
+          );
+
+          return { id, ...attributes };
+        });
+      } else {
+        attributeValues[key] = property;
+      }
     } else if (attribute && attribute.type === 'media') {
       const data = transformEntry(property, strapi.contentType('plugin::upload.file'));
 

packages/core/strapi/tests/dynamiczones/with-media.test.e2e.js

@@ -126,19 +126,27 @@ describe('Not required dynamiczone', () => {
               id: expect.anything(),
               __component: 'default.one-media',
               media: {
-                id: mediaId,
+                data: {
-                url: expect.any(String),
+                  id: mediaId,
+                  attributes: expect.objectContaining({
+                    url: expect.any(String),
+                  }),
+                },
               },
             },
             {
               id: expect.anything(),
               __component: 'default.many-media',
-              media: expect.arrayContaining([
+              media: {
-                expect.objectContaining({
+                data: expect.arrayContaining([
-                  id: mediaId,
+                  expect.objectContaining({
-                  url: expect.any(String),
+                    id: mediaId,
-                }),
+                    attributes: expect.objectContaining({
-              ]),
+                      url: expect.any(String),
+                    }),
+                  }),
+                ]),
+              },
             },
           ],
         },
@@ -209,19 +217,27 @@ describe('Not required dynamiczone', () => {
               id: expect.anything(),
               __component: 'default.one-media',
               media: {
-                id: newMediaId,
+                data: {
-                url: expect.any(String),
+                  id: newMediaId,
+                  attributes: expect.objectContaining({
+                    url: expect.any(String),
+                  }),
+                },
               },
             },
             {
               id: expect.anything(),
               __component: 'default.many-media',
-              media: expect.arrayContaining([
+              media: {
-                expect.objectContaining({
+                data: expect.arrayContaining([
-                  id: newMediaId,
+                  expect.objectContaining({
-                  url: expect.any(String),
+                    id: newMediaId,
-                }),
+                    attributes: expect.objectContaining({
-              ]),
+                      url: expect.any(String),
+                    }),
+                  }),
+                ]),
+              },
             },
           ],
         },
@@ -273,19 +289,27 @@ describe('Not required dynamiczone', () => {
               id: expect.anything(),
               __component: 'default.one-media',
               media: {
-                id: mediaId,
+                data: {
-                url: expect.any(String),
+                  id: mediaId,
+                  attributes: expect.objectContaining({
+                    url: expect.any(String),
+                  }),
+                },
               },
             },
             {
               id: expect.anything(),
               __component: 'default.many-media',
-              media: expect.arrayContaining([
+              media: {
-                expect.objectContaining({
+                data: expect.arrayContaining([
-                  id: mediaId,
+                  expect.objectContaining({
-                  url: expect.any(String),
+                    id: mediaId,
-                }),
+                    attributes: expect.objectContaining({
-              ]),
+                      url: expect.any(String),
+                    }),
+                  }),
+                ]),
+              },
             },
           ],
         },
@@ -333,17 +357,25 @@ describe('Not required dynamiczone', () => {
               __component: 'default.with-nested',
               singleMedia: {
                 media: {
-                  id: mediaId,
+                  data: {
-                  url: expect.any(String),
+                    id: mediaId,
+                    attributes: expect.objectContaining({
+                      url: expect.any(String),
+                    }),
+                  },
                 },
               },
               multipleMedia: {
-                media: expect.arrayContaining([
+                media: {
-                  expect.objectContaining({
+                  data: expect.arrayContaining([
-                    id: mediaId,
+                    expect.objectContaining({
-                    url: expect.any(String),
+                      id: mediaId,
-                  }),
+                      attributes: expect.objectContaining({
-                ]),
+                        url: expect.any(String),
+                      }),
+                    }),
+                  ]),
+                },
               },
             },
           ],