PR review

Signed-off-by: Virginie Ky <virginie.ky@gmail.com>
This commit is contained in:
Virginie Ky 2020-02-26 15:52:19 +01:00
parent 22cd052a90
commit 23e4ab38bd
2 changed files with 5 additions and 5 deletions

View File

@ -4,7 +4,7 @@ import PropTypes from 'prop-types';
import Wrapper from './Wrapper'; import Wrapper from './Wrapper';
import SortListItem from '../SortListItem'; import SortListItem from '../SortListItem';
const SortList = ({ isShown, list, onClick, selected }) => { const SortList = ({ isShown, list, onClick, selectedItem }) => {
return ( return (
<Wrapper isShown={isShown}> <Wrapper isShown={isShown}>
{Object.keys(list).map(item => { {Object.keys(list).map(item => {
@ -14,7 +14,7 @@ const SortList = ({ isShown, list, onClick, selected }) => {
label={item} label={item}
value={list[item]} value={list[item]}
onClick={onClick} onClick={onClick}
selectedItem={selected} selectedItem={selectedItem}
/> />
); );
})} })}
@ -26,14 +26,14 @@ SortList.defaultProps = {
list: {}, list: {},
isShown: false, isShown: false,
onClick: () => {}, onClick: () => {},
selected: null, selectedItem: null,
}; };
SortList.propTypes = { SortList.propTypes = {
list: PropTypes.object, list: PropTypes.object,
isShown: PropTypes.bool, isShown: PropTypes.bool,
onClick: PropTypes.func, onClick: PropTypes.func,
selected: PropTypes.string, selectedItem: PropTypes.string,
}; };
export default SortList; export default SortList;

View File

@ -38,7 +38,7 @@ const SortPicker = ({ onChange, value }) => {
<SortList <SortList
isShown={isOpen} isShown={isOpen}
list={orders} list={orders}
selected={value} selectedItem={value}
onClick={handleChange} onClick={handleChange}
/> />
</Wrapper> </Wrapper>