test for circular references

packages/core/database/lib/entity-manager/__tests__/sort-connect-array.test.js

@@ -45,4 +45,20 @@ describe('sortConnectArray', () => {
       'There was a problem connecting relation with id 1 at position {"after":2}. The relation with id 2 needs to be connected first.'
     );
   });
+
+  test('error with circular references', () => {
+    const sortConnect = () =>
+      sortConnectArray(
+        [
+          { id: 2, position: { after: 1 } },
+          { id: 3, position: { after: 1 } },
+          { id: 1, position: { after: 3 } },
+        ],
+        []
+      );
+
+    expect(sortConnect).toThrowError(
+      'A circular reference was found in the connect array. One relation is trying to connect before/after another one that is trying to connect before/after it'
+    );
+  });
 });

packages/core/database/lib/entity-manager/relations-orderer.js

@@ -44,6 +44,7 @@ const sortConnectArray = (connectArr, initialArr = [], strictSort = true) => {
   if (!needsSorting) return connectArr;
 
   // Iterate over connectArr and populate sortedConnect
+  try {
     connectArr.forEach((rel, idx) => {
       const pushRelation = (rel) => {
         sortedConnect.push(rel);
@@ -85,6 +86,16 @@ const sortConnectArray = (connectArr, initialArr = [], strictSort = true) => {
 
       computeRelation(rel);
     });
+  } catch (err) {
+    // If it is a RangeError, there is a circular dependency in the connect array.
+    if (err instanceof RangeError)
+      throw new InvalidRelationError(
+        'A circular reference was found in the connect array. ' +
+          'One relation is trying to connect before/after another one that is trying to connect before/after it'
+      );
+
+    throw err;
+  }
 
   return sortedConnect;
 };