From 2cfe18cedbccd93cb11d412bee0c609c66d01d68 Mon Sep 17 00:00:00 2001 From: cyril lopez Date: Wed, 12 Jul 2017 16:18:58 +0200 Subject: [PATCH] remove useless console log change leftmenu stateless function to react component --- .../src/components/PluginLeftMenu/index.js | 28 +++++++++++++++---- .../components/PluginLeftMenuSection/index.js | 20 +++++++++++++ .../PluginLeftMenuSection/styles.scss | 3 ++ .../PluginLeftMenuSection/tests/index.test.js | 11 ++++++++ .../admin/src/containers/App/index.js | 5 ++-- .../admin/src/containers/App/reducer.js | 2 +- 6 files changed, 59 insertions(+), 10 deletions(-) create mode 100644 packages/strapi-plugin-setings-manager/admin/src/components/PluginLeftMenuSection/index.js create mode 100644 packages/strapi-plugin-setings-manager/admin/src/components/PluginLeftMenuSection/styles.scss create mode 100644 packages/strapi-plugin-setings-manager/admin/src/components/PluginLeftMenuSection/tests/index.test.js diff --git a/packages/strapi-plugin-setings-manager/admin/src/components/PluginLeftMenu/index.js b/packages/strapi-plugin-setings-manager/admin/src/components/PluginLeftMenu/index.js index afd3f5c424..e5db9618b4 100644 --- a/packages/strapi-plugin-setings-manager/admin/src/components/PluginLeftMenu/index.js +++ b/packages/strapi-plugin-setings-manager/admin/src/components/PluginLeftMenu/index.js @@ -9,12 +9,28 @@ import React from 'react'; import PluginLeftMenuHeader from 'components/PluginLeftMenuHeader'; import styles from './styles.scss'; -function PluginLeftMenu() { - return ( -
- -
- ); +class PluginLeftMenu extends React.Component { // eslint-disable-line react/prefer-stateless-function + constructor(props) { + super(props); + } + + render() { + return ( +
+ +
+ ); + } } + + +// function PluginLeftMenu() { +// return ( +//
+// +//
+// ); +// } + export default PluginLeftMenu; diff --git a/packages/strapi-plugin-setings-manager/admin/src/components/PluginLeftMenuSection/index.js b/packages/strapi-plugin-setings-manager/admin/src/components/PluginLeftMenuSection/index.js new file mode 100644 index 0000000000..9808e26b0b --- /dev/null +++ b/packages/strapi-plugin-setings-manager/admin/src/components/PluginLeftMenuSection/index.js @@ -0,0 +1,20 @@ +/** +* +* PluginLeftMenuSection +* +*/ + +import React from 'react'; + +import styles from './styles.scss'; + +class PluginLeftMenuSection extends React.Component { // eslint-disable-line react/prefer-stateless-function + render() { + return ( +
+
+ ); + } +} + +export default PluginLeftMenuSection; diff --git a/packages/strapi-plugin-setings-manager/admin/src/components/PluginLeftMenuSection/styles.scss b/packages/strapi-plugin-setings-manager/admin/src/components/PluginLeftMenuSection/styles.scss new file mode 100644 index 0000000000..7cc932c4f2 --- /dev/null +++ b/packages/strapi-plugin-setings-manager/admin/src/components/PluginLeftMenuSection/styles.scss @@ -0,0 +1,3 @@ +.pluginLeftMenuSection { /* stylelint-disable */ + +} diff --git a/packages/strapi-plugin-setings-manager/admin/src/components/PluginLeftMenuSection/tests/index.test.js b/packages/strapi-plugin-setings-manager/admin/src/components/PluginLeftMenuSection/tests/index.test.js new file mode 100644 index 0000000000..ceb92b0f1c --- /dev/null +++ b/packages/strapi-plugin-setings-manager/admin/src/components/PluginLeftMenuSection/tests/index.test.js @@ -0,0 +1,11 @@ +// import PluginLeftMenuSection from '../index'; + +import expect from 'expect'; +// import { shallow } from 'enzyme'; +// import React from 'react'; + +describe('', () => { + it('Expect to have unit tests specified', () => { + expect(true).toEqual(false); + }); +}); diff --git a/packages/strapi-plugin-setings-manager/admin/src/containers/App/index.js b/packages/strapi-plugin-setings-manager/admin/src/containers/App/index.js index 7087a33bd8..ad67697595 100644 --- a/packages/strapi-plugin-setings-manager/admin/src/containers/App/index.js +++ b/packages/strapi-plugin-setings-manager/admin/src/containers/App/index.js @@ -41,13 +41,12 @@ class App extends React.Component { exposedComponents: this.props.exposedComponents, }) ); - console.log(this.props.app) return (
- +
{React.Children.toArray(content)} @@ -61,7 +60,7 @@ App.contextTypes = { }; App.propTypes = { - children: React.PropTypes.node.isRequired, + children: React.PropTypes.node, exposedComponents: React.PropTypes.object.isRequired, }; diff --git a/packages/strapi-plugin-setings-manager/admin/src/containers/App/reducer.js b/packages/strapi-plugin-setings-manager/admin/src/containers/App/reducer.js index 01d81d2fe5..c302cf9b88 100644 --- a/packages/strapi-plugin-setings-manager/admin/src/containers/App/reducer.js +++ b/packages/strapi-plugin-setings-manager/admin/src/containers/App/reducer.js @@ -10,7 +10,7 @@ import { } from './constants'; const initialState = fromJS({ - sections: List() + sections: List(), }); function appReducer(state = initialState, action) {